Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test folding improvements #46588

Closed
2 tasks done
aeschli opened this issue Mar 26, 2018 · 1 comment
Closed
2 tasks done

Test folding improvements #46588

aeschli opened this issue Mar 26, 2018 · 1 comment
Labels
testplan-item
Milestone
March 2018

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 26, 2018 •
edited by dbaeumer

Test for #45981:

Complexity: 3

Cancellation with folding providers and limiting the number of transmitted regions to 5000.

  • open a very large JSON file
  • collapse some regions
  • observe the folding ranges while typing.
    -> the collapse regions should never unfold
    -> no slowness can be observed, no old regions applied
  • enable tracing for the JSON language server ("json.trace.server": "messages") to see which folding requests go through.

Multi-line comments

  • test multi line comments in JSON and HTML and verify that they can be folded
@vscodebot vscodebot bot added the editor label Mar 26, 2018
@aeschli aeschli added this to the March 2018 milestone Mar 26, 2018
@aeschli aeschli assigned aeschli and unassigned aeschli Mar 26, 2018
@sandy081 sandy081 assigned bpasero and unassigned auchenberg Mar 27, 2018
@bpasero bpasero mentioned this issue Mar 27, 2018
Closed
@bpasero bpasero removed their assignment Mar 27, 2018
@bpasero
Copy link
Member

bpasero commented Mar 27, 2018

I noticed some slowdown on a 50k HTML file when I typed and immediately expanded a node below. Not sure if this should be looked at @aeschli

@dbaeumer dbaeumer mentioned this issue Mar 27, 2018
Closed
@dbaeumer dbaeumer removed their assignment Mar 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
5 participants
@auchenberg @rebornix @bpasero @dbaeumer @aeschli