Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folding] Folded regions are lost when starting multi line comment #46655

Closed
bpasero opened this issue Mar 27, 2018 · 1 comment
Closed

[folding] Folded regions are lost when starting multi line comment #46655

bpasero opened this issue Mar 27, 2018 · 1 comment
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues html HTML support issues verified Verification succeeded
Milestone
March 2018

Comments

@bpasero
Copy link
Member

bpasero commented Mar 27, 2018

Refs: #46588

  • collapse some elements in HTML
  • open a multi line comment to the top

=> all folded regions below are lost when you close the comment
@aeschli aeschli changed the title Folded regions are lost when starting multi line comment [folding] Folded regions are lost when starting multi line comment Mar 28, 2018
@aeschli aeschli added editor-folding Editor code folding issues html HTML support issues labels Mar 28, 2018
@aeschli aeschli added this to the March 2018 milestone Mar 28, 2018
@aeschli
Copy link
Contributor

aeschli commented Mar 28, 2018 •
edited
Loading

I fixed this by having <!-- auto closing with -->.
That will avoid the scenario above (which still can happen, but is difficult to track and improve)

@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2018
@sbatten sbatten added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues html HTML support issues verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
3 participants
@bpasero @aeschli @sbatten