Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large file notification doesn't show when opening fresh Code #46765

Closed
roblourens opened this issue Mar 27, 2018 · 1 comment
Closed

Large file notification doesn't show when opening fresh Code #46765

roblourens opened this issue Mar 27, 2018 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone
June 2018

Comments

@roblourens
Copy link
Member

Testing #46602

  • Close all instances of vscode
  • Run code-insiders myLargeFile.txt
  • Empty code window opens, no file or notification
@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2018
@sbatten
Copy link
Member

sbatten commented May 4, 2018

After investigation, this looks to be caused because the partService is not ready in doHandleSetInputError in editorPart.ts … I think we may be needing to check the notificationService instead. Assigning to @bpasero

@sbatten sbatten assigned bpasero and unassigned sbatten May 4, 2018
@bpasero bpasero modified the milestones: May 2018, June 2018 May 6, 2018
@bpasero bpasero added the workbench-editors Managing of editor widgets in workbench window label May 11, 2018
bpasero added a commit that referenced this issue May 11, 2018
@bpasero
grid - show errors after being restored (for #46765)
b8919d5
@bpasero bpasero closed this as completed Jun 2, 2018
@mjbvz mjbvz added the verified Verification succeeded label Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
4 participants
@roblourens @bpasero @sbatten @mjbvz