Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't localize command names on the command palette #4679
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Related to this, it would be good to introduce aliases to some commands in the command palette. For example "Reload Window" could have the alias "Restart Window" to improve discoverability. |
This comment has been minimized.
This comment has been minimized.
|
@espresso3389 which IME are you using? And which version of Windows? |
This comment has been minimized.
This comment has been minimized.
|
I'm on Windows 10 and the IME is ATOK; a Japanese thirdparty IME. |
This comment has been minimized.
This comment has been minimized.
|
I totally agree with @Tyriar. What we really need is "command alias" in the case. With such aliases, I don't want to stop Japanese localization. |
This comment has been minimized.
This comment has been minimized.
|
@expresso3389 I moved the IME bug over to #4691, this issue can discuss whether or not the command palette should be translated and to what extent. |
This comment has been minimized.
This comment has been minimized.
|
Not translating the command names doesn't make too much sense to me. Why only the command names? IMO we need to fix the filtering tracked in #4691. And aliases would only help if they are user definable since Restart Window would be translated as well. In general I think the command palette filtering should be improved where the command provide can provide additional search and filter strings. @bpasero I move this to you to consider improving the command palette with additional filter / search strings. |
This comment has been minimized.
This comment has been minimized.
|
I would suggest that we do not mix english strings together with other language strings but rather ask our users to change the language to english for the entire application (F1 > Configure Language). I leave this decision up to our PM @chrisdias |
This comment has been minimized.
This comment has been minimized.
|
@bpasero remember though that "mixing languages" may be natural depending on the language. I imagine typing |
This comment has been minimized.
This comment has been minimized.
|
Yeah, I see the issue for commands that are really close to their terminal counter parts. |
This comment has been minimized.
This comment has been minimized.
|
Maybe we should just document for those NLS strings that they should not get translated at all? |
This comment has been minimized.
This comment has been minimized.
|
I have just installed VS Code Insiders and found all the commands are translated. eg. when installing an extension instead of typing My Windows language is Chinese. I have to guess which Chinese word I should use when referring to the VS Code Docs, however which word should be used is decided by the translator. And as you can see it's too boring to input EAST Asia words. There is a Chinese idiom 过犹不及 which means too much of a good thing. |
This comment has been minimized.
This comment has been minimized.
|
As a Chinese user who do l10n work for Mozilla Firefox, I strongly suggest you DO NOT translate command strings in command panel. I have to try to translate all the command I want to use to Chinese exactly identical to your translation, that is very painful. You can just give out an explanation which is shown when mouse is on the command name and just translate the explanation. |
This comment has been minimized.
This comment has been minimized.
|
BTW, there should be a "UI language" in the User Settings, instead of only showing in the language which is the running OS' default UI language. |
This comment has been minimized.
This comment has been minimized.
|
@showerying you can set the locale from the command line or in a |
This comment has been minimized.
This comment has been minimized.
|
A better solution should be show the translated version and the original version side-by-side and search the command using both of them. |
This comment has been minimized.
This comment has been minimized.
|
Have you ever considered the length of a string and the width of the command palette? If both versions are shown we need to solve this problem so our users can see a full string. |
This comment has been minimized.
This comment has been minimized.
|
@be5invis agree, keywords can be a useful concept in cases where you can describe the command with different words. I am fine leaving that in for matching but I would not show keywords anywhere in the UI. |
This comment has been minimized.
This comment has been minimized.
|
@bpasero But if you decide to display English label as primary, then the keywords is less useful, but I think it still worth preserving. |
This comment has been minimized.
This comment has been minimized.
|
To be clear, the keywords currently are english and are not translated. If we decide to keep keywords, the interesting challenge is that you would probably need to have both translated keywords and english. Hence I am thinking of not keeping keywords (we never had them and imho they are separate from the discussion here and just nice to have). |
This comment has been minimized.
This comment has been minimized.
|
@bpasero My main idea is that, if users can directly see the English label clearly (which means that the primary label is in English, not translated), then the English keywords are less important. However, if what they directly see is translated, then they may come up with synonyms of the English command, and the keywords are very useful now. |
This comment has been minimized.
This comment has been minimized.
|
Well I propose to show english always first and the translated label below less prominent, hence we both agree that keywords are not needed. |
This comment has been minimized.
This comment has been minimized.
|
@bpasero Agree with you. |
This comment has been minimized.
This comment has been minimized.
|
Thanks everyone for the great discussion on this topic. We appreciate all of the feedback and especially the insight on how you use the tool in both english and native languages. This was valuable input into our UX design meeting @egamma mentioned above, so I wanted to share with you the results of our conversation. Here is what we decided:
We only have a small window to get this into the current iteration and given the feedback here, we think we've got the right design, so we're going to push forward with this plan. We expect to do another Insiders drop early next week and then ship this in the April release. From there, we can then make modifications to the experience in the next iteration (if necessary!). Thanks again, we think we will have a much better and much more natural experience because of your input. |
This comment has been minimized.
This comment has been minimized.
|
Happying ending |
This comment has been minimized.
This comment has been minimized.
|
Pushed. |
This comment has been minimized.
This comment has been minimized.
|
We did a decision today in the team to show the localized command first and the english one below. @stevencl @bgashler1 @chrisdias fyi |
This comment has been minimized.
This comment has been minimized.
|
@bpasero So, re-enable keywords? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Oh translated and English is in same size |
This comment has been minimized.
This comment has been minimized.
|
The rationale for this change was to emphasize the fact that the UI is translated to a certain language. Showing the english labels enables to find and memorize the english commands for faster typing but the UI is otherwise consistently translated. Showing the english label first would draw the wrong impression about the primary language of VS Code. |
This comment has been minimized.
This comment has been minimized.
|
@bpasero |
This comment has been minimized.
This comment has been minimized.
|
@espresso3389 is it that you want the translation below? Or would you prefer to disable the translation completely and just use English. If so, we do allow you to turn it off. |
This comment has been minimized.
This comment has been minimized.
|
@bgashler1 Make it configurable will be better |
This comment has been minimized.
This comment has been minimized.
Yes, it would be better "for me" if I can choose which one comes first. |
This comment has been minimized.
This comment has been minimized.
|
Considering that the English version is the "primary" one, at least for CJK languages, I think it makes sense for that to come first. This may not be the same for languages that don't use an IME though. |
This comment has been minimized.
This comment has been minimized.
|
By the way,can I change font sizes? |
This comment has been minimized.
This comment has been minimized.
|
Agree with @WhiteCat6142. |



バージョン 0.10.12-insider
コミット ef2a1fc
日付 2016-03-21T11:33:38.240Z
シェル 0.35.6
レンダラー 45.0.2454.85
ノード 4.1.1
Even Japanese people, typing Japanese words are very painful and time-consuming because of IME composition problems.
We expects that the commands are all in English.
For example, if I want to execute git pull, I will type "git pull"; not "git プル".
Hope you can understand our situation.