Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome page background color #46816

Closed
icokk opened this issue Mar 28, 2018 · 4 comments
Closed

Welcome page background color #46816

icokk opened this issue Mar 28, 2018 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors themes Color theme issues workbench-welcome Welcome page issues

Comments

@icokk
Copy link

icokk commented Mar 28, 2018

Welcome page's background is always set to editor background, while welcome page foreground colors depend on the theme (dark foreground for light theme, light foreground for dark theme). This makes welcome page unreadable in case that you have dark editor background with light theme. The same problem happens for extension documentation page.

Would it be possible to add a setting for welcome page background (it can also apply to extension documentation page and other embedded web pages)? To maintain background compatibility, it can default to editor background when not set.

Examples:

image

image

@vscodebot vscodebot bot added the themes Color theme issues label Mar 28, 2018
@chrmarti chrmarti added feature-request Request for new features or functionality workbench-welcome Welcome page issues labels Mar 28, 2018
@chrmarti chrmarti added the good first issue Issues identified as good for first-time contributors label Oct 2, 2018
@audoralc
Copy link

audoralc commented Oct 2, 2018

I'd be happy to take a look into this if help is still needed.

@chrmarti
Copy link
Contributor

chrmarti commented Oct 3, 2018

@audoralc Yes, should be a small change from what I see. Next to and similar to the button colors here: https://github.com/Microsoft/vscode/blob/d1571770ce9f6fdb98e8ee19d7711498a35bfdd0/src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts#L590

@defaults
Copy link

defaults commented Oct 4, 2018

@audoralc have you already started on this or can i take this up?

@audoralc
Copy link

audoralc commented Oct 4, 2018

@defaults I have already started

greybax pushed a commit to greybax/vscode that referenced this issue Oct 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors themes Color theme issues workbench-welcome Welcome page issues
Projects
None yet
Development

No branches or pull requests

4 participants