Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi select: focus lost when clicking an item? #46926

Closed
bpasero opened this issue Mar 29, 2018 · 5 comments
Closed

Multi select: focus lost when clicking an item? #46926

bpasero opened this issue Mar 29, 2018 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 29, 2018

flicker_chrome58

It looks like once I click into an item focus is neither in the list nor in the input field?

@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Mar 29, 2018
@chrmarti
Copy link
Contributor

The focus ends up on the checkbox. 🤔

@bpasero
Copy link
Member Author

bpasero commented Mar 29, 2018

@chrmarti ah I did not see that, maybe it should just jump back to the input field?

@chrmarti
Copy link
Contributor

That works for mouse operation. You can still tab through all checkboxes, which might or might not be expected given that the list already has a focus cursor to move through all elements. Do you understand the accessibility side of this?

@chrmarti chrmarti added this to the March 2018 milestone Mar 29, 2018
@gushuro gushuro added the verified Verification succeeded label Mar 30, 2018
@gushuro
Copy link
Contributor

gushuro commented Mar 30, 2018

There's still an issue if you click and release the button outside the item.
Focus goes to the item clicked and typing doesn't work. Furthermore, if I navigate using arrow keys the item keeps its decoration.

multipickdrag

@gushuro gushuro reopened this Mar 30, 2018
@gushuro gushuro removed the verified Verification succeeded label Mar 30, 2018
@chrmarti
Copy link
Contributor

chrmarti commented Apr 1, 2018

Fixing this by clearing the selection. There is still the corner case where the list keeps the focus when the mouse button is released outside the item. That would need more investigation into the order of events to fix.

@chrmarti chrmarti added the candidate Issue identified as probable candidate for fixing in the next release label Apr 1, 2018
chrmarti added a commit that referenced this issue Apr 1, 2018
@mjbvz mjbvz added the verified Verification succeeded label Apr 2, 2018
@chrmarti chrmarti removed the candidate Issue identified as probable candidate for fixing in the next release label Apr 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@bpasero @gushuro @chrmarti @mjbvz and others