Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TypeScript 2.9 disableSuggestions preference #47617

Closed
mjbvz opened this issue Apr 10, 2018 · 3 comments
Closed

Support TypeScript 2.9 disableSuggestions preference #47617

mjbvz opened this issue Apr 10, 2018 · 3 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2018

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 10, 2018

From microsoft/TypeScript#23283

Support the disableSuggestions preference for typescript. You can already hide these errors with "javascript.suggestionActions.enabled": false and "typescript.suggestionActions.enabled": false. This feature would just hook these settings up to typescript so that we don't compute the suggestions if they are not enabled
@mjbvz mjbvz added feature-request Request for new features or functionality typescript Typescript support issues labels Apr 10, 2018
@mjbvz mjbvz added this to the May 2018 milestone Apr 10, 2018
@mjbvz mjbvz self-assigned this Apr 10, 2018
@mjbvz mjbvz added the verification-needed Verification of issue is requested label May 4, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented May 4, 2018

For verification, create a file with an unused variable and try triggering quick fixes for it. None should be returned when javascript.suggestionActions.enabled is false

@mjbvz mjbvz closed this as completed May 4, 2018
mjbvz added a commit that referenced this issue May 4, 2018
@mjbvz
Support TS disable suggestions setting
7265881 
Fixes #47617
@kieferrm kieferrm mentioned this issue May 14, 2018
Closed
46 tasks
@roblourens
Copy link
Member

I still see this, is it wrong?

image

@roblourens roblourens reopened this May 30, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented May 30, 2018 •
edited
Loading

That's a quick fix instead of a suggestion because there's a warning. Try this in a project that does not have noUnusedLocals set

(Note this setting will also turn of graying out of unused variables)

@mjbvz mjbvz closed this as completed May 30, 2018
@roblourens roblourens added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@roblourens @mjbvz