-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renderer consumes CPU after update to latest Insiders version #47883
Comments
@kirusyaga can you run " |
@bpasero The output is here:
|
adding @joaomoreno for the (maybe unrelated) spdylog stacktrace that shows up. @kirusyaga can you share a screenshot how VSCode looks after it started like this? |
@kirusyaga does it make any difference if you run with " |
That literal @kirusyaga Whats the value of your HOMEPATH variable? |
@bpasero Visually nothing is changed. In console also nothing. |
@kirusyaga does it make any difference if you run " |
@bpasero Yes. Window is opening like normal new profile. My profile is broken. Nice. UPD: Erased my old profile. Nothing. Same situation. |
@kirusyaga to verify that can you use the |
@bpasero Yes. Launch with Cyrillic characters in path give same result. |
@kirusyaga it would be easier for me to reproduce if you could post the exact Cyrillic letters that you are using in here as text so that I can copy it. |
@bpasero Here it is: |
@joaomoreno I can reproduce and the reason the workbench is not coming up is due to spdylog crashing very early. To reproduce run "
|
@bpasero Just to confirm, you could reproduce by using cyrilic in a path provided to |
@joaomoreno I can. Command:
|
@joaomoreno yes |
I can confirm I have an identical problem. My username contains the character 'ø', which now makes the insiders build fail to start. Changing the EDIT: |
@sandy081 I don't see issues running dev with a user-data-dir containing a non-ascii character (eg |
I too do not see any issues after removing the workaround I added before for the crash. Hence removed the workaround. To verify:
|
Reopening this as the crash from spdlog is not fixed. |
@joaomoreno I still see following error in the console with our log files
Edit: This is seen in the console even with the workaround. Workaround just mitigates it by falling back to old output channels. Logs will not work though. |
Updated node-spdlog library to support With this crash no longer occurs with non ascii or special characters (tested with all reported characters). Added a smoke test to launch VS Code with special characters in user data dir. |
After update to latest version window is empty (only main menu bar is visible).
Renderer process consumes 16-20% CPU but nothing is changing.
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: