Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #45853 #47886

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Fix #45853 #47886

merged 2 commits into from
Oct 2, 2018

Conversation

andrewtomai
Copy link
Contributor

@andrewtomai andrewtomai commented Apr 15, 2018

Issue #45853
Automatically navigate to the next merge conflict when you resolve the current conflict. Added a default setting to the user settings JSON, under the Merge Conflict settings to allow the user to disable this feature if they so choose.

@chrmarti chrmarti added this to the April 2018 milestone Apr 17, 2018
@chrmarti chrmarti added the merge-conflict Merge conflict decorations and actions label Apr 17, 2018
@chrmarti
Copy link
Contributor

Thanks @andrewtomai !

When I use the merge conflict code lenses I sometimes want to stay at the conflict after I have chosen a resolution because I need to fix things up. Only sometimes I want to move on immediately. A setting doing either one or the other wouldn't work too well for me.

It would be better if we had an easy way to navigate to the next conflict after the current one is resolved through one of the actions and possible edited.

Related: #47884

@chrmarti
Copy link
Contributor

I suggest to change #47884 to add toolbar items to the editor when there are merge conflicts instead of the proposed change here. That will allow the user to continue editing the result of the merge action and then navigate to the previous/next merge conflict easily.

@chrmarti chrmarti merged commit 3af967d into microsoft:master Oct 2, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge-conflict Merge conflict decorations and actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants