Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #38321 -- Provide navigation through git merge conflicts with codelens #47884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #38321 -- Provide navigation through git merge conflicts with codelens #47884

wants to merge 1 commit into from

Conversation

andrewtomai
Copy link
Contributor

@andrewtomai andrewtomai commented Apr 14, 2018

#38321
It should first be noted that the "next conflict" and "previous conflict" buttons will not be present if there is only 1 merge conflict in the current file.

It should also be noted that this navigation does not go between files. For example, if there are 2 conflicts in file A and 2 conflicts in file B, the "next conflict" button will not ever switch between the two files.

@msftclas
Copy link

msftclas commented Apr 14, 2018

CLA assistant check
All CLA requirements met.

@andrewtomai andrewtomai changed the title Issue #38321 -- Provide navigation through git merge conflicts with codelens Fix #38321 -- Provide navigation through git merge conflicts with codelens Apr 14, 2018
@chrmarti chrmarti added this to the April 2018 milestone Apr 17, 2018
@chrmarti chrmarti added the merge-conflict Merge conflict decorations and actions label Apr 17, 2018
@chrmarti
Copy link
Contributor

Thanks @andrewtomai !

I don't like that this makes the list of code lenses even longer:

image

@chrmarti chrmarti mentioned this pull request Apr 17, 2018
@chrmarti
Copy link
Contributor

I suggest to add 'Previous Merge Conflict' and 'Next Merge Conflict' toolbar items to the editor when there are merge conflicts instead of the proposed change here. That will also cover part of the pain point discussed in #47886.

@chrmarti
Copy link
Contributor

Here is an example of how to conditionally show actions in the editor context menu, a similar approach can be used here:

The diff editor already comes with previous/next toolbar items, yours could look the same:
image

@andrewtomai
Copy link
Contributor Author

Okay! Ill attempt to make this change!

@chrmarti chrmarti removed this from the April 2018 milestone Apr 23, 2018
@isuvorov
Copy link

+1

1 similar comment
@Yukioru
Copy link

Yukioru commented Jul 18, 2018

+1

@Kingwl Kingwl mentioned this pull request May 12, 2020
@FDiskas
Copy link

FDiskas commented Nov 13, 2020

Why the merge tool is so ugly? Looks like somebody got brainfart implementing this :D
Ok sorry, but could you do this in better way?
Like it is done "Sublime merge", "JetBrains"
image
image

It's almost done by clicking on "Compare Changes" but it's read only. So lets do it this way - make left side (local copy) editable so the user just could copy some stuff from incoming changes.

As a solution currently I'm using online tool to compare and apply changes :D

@joaomoreno joaomoreno changed the base branch from master to main February 15, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict Merge conflict decorations and actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants