New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #38321 -- Provide navigation through git merge conflicts with codelens #47884
base: main
Are you sure you want to change the base?
Conversation
Thanks @andrewtomai ! I don't like that this makes the list of code lenses even longer: |
I suggest to add 'Previous Merge Conflict' and 'Next Merge Conflict' toolbar items to the editor when there are merge conflicts instead of the proposed change here. That will also cover part of the pain point discussed in #47886. |
Here is an example of how to conditionally show actions in the editor context menu, a similar approach can be used here:
The diff editor already comes with previous/next toolbar items, yours could look the same: |
Okay! Ill attempt to make this change! |
+1 |
1 similar comment
+1 |
#38321
It should first be noted that the "next conflict" and "previous conflict" buttons will not be present if there is only 1 merge conflict in the current file.
It should also be noted that this navigation does not go between files. For example, if there are 2 conflicts in file A and 2 conflicts in file B, the "next conflict" button will not ever switch between the two files.