Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests timeout: workspace-namespace registerTextDocumentContentProvider, change event #48192

Closed
joaomoreno opened this issue Apr 19, 2018 · 9 comments
Assignees
Labels
debt Code quality issues

Comments

@joaomoreno
Copy link
Member

Repros not so often, but just happened:

2018-04-19T08:57:46.6886760Z �[92m �[0m�[32m 82 passing�[0m�[90m (1m)�[0m
2018-04-19T08:57:46.6912300Z �[31m  1 failing�[0m
2018-04-19T08:57:46.6925370Z 
2018-04-19T08:57:46.6950290Z �[0m  1) workspace-namespace registerTextDocumentContentProvider, change event:
2018-04-19T08:57:46.6980410Z �[0m�[31m     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.�[0m�[90m

https://monacotools.visualstudio.com/Monaco/_build/index?buildId=38404&_a=summary

@bpasero
Copy link
Member

bpasero commented Apr 19, 2018

I don't think I added that test to be honest. @jrieken ?

@joaomoreno
Copy link
Member Author

Actually just failed again:

https://monacotools.visualstudio.com/Monaco/_build/index?buildId=38405&_a=summary

Maybe there was a new change pushed today/yesterday?

It seems to only fail on macOS.

@jrieken jrieken added the debt Code quality issues label Apr 19, 2018
@jrieken
Copy link
Member

jrieken commented Apr 19, 2018

I didn't touch anything...

@joaomoreno
Copy link
Member Author

One more failure: https://monacotools.visualstudio.com/Monaco/_build/index?buildId=38456&_a=summary

Though it is still random, it seems it happens much more often now.

@bpasero bpasero removed their assignment Apr 23, 2018
@jrieken
Copy link
Member

jrieken commented Jun 5, 2018

Pushed a change to de-register the listener later. This should/could make this more stable, tho I have also not seen this failing in a while.

jrieken added a commit that referenced this issue Jun 5, 2018
@jrieken
Copy link
Member

jrieken commented Jun 5, 2018

Optimistically closing

@jrieken jrieken closed this as completed Jun 5, 2018
@joaomoreno
Copy link
Member Author

joaomoreno commented Jun 6, 2018

Sorry dude :( https://vscode.visualstudio.com/VSCode/_build?buildId=1475

Big coincidence that it just hit today.

@joaomoreno joaomoreno reopened this Jun 6, 2018
@jrieken
Copy link
Member

jrieken commented Jun 6, 2018

maybe too optimistically... tho I have no clue what's going on...

@jrieken
Copy link
Member

jrieken commented Mar 6, 2019

No, I really have seen this failing in a long while. Staying optimistically.

@jrieken jrieken closed this as completed Mar 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

3 participants