Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: Unit tests configuration should run in real electron and not node.js environment #48205

Closed
bpasero opened this issue Apr 19, 2018 · 1 comment
Labels
engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code

Comments

@bpasero
Copy link
Member

bpasero commented Apr 19, 2018

We can no longer run the unit tests via the debug configuration because some tests drag in fileService.ts which recently started to move to electron-browser. Instead of finding a solution for this while keeping node.js, we should instead allow the unit tests to execute in an Electron environment, in the same way they run when running from the command line.

Thanks @weinand for reporting this. It would probably require to connect the debugger to the Electron renderer via the chrome debugger (cc @roblourens).

@bpasero bpasero added the debt Code quality issues label Apr 19, 2018
@bpasero bpasero added this to the April 2018 milestone Apr 19, 2018
@bpasero bpasero self-assigned this Apr 19, 2018
@bpasero bpasero removed this from the April 2018 milestone Apr 20, 2018
@bpasero bpasero changed the title FileService drags in electron which prevents running tests in VSCode Debug: Unit tests configuration should run in real electron and not node.js environment Apr 20, 2018
@bpasero bpasero added feature-request Request for new features or functionality engineering VS Code - Build / issue tracking / etc. and removed debt Code quality issues labels Apr 20, 2018
@bpasero bpasero removed their assignment Apr 26, 2018
@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Oct 10, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

1 participant