Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install task should be available by default in npm extension #48456

Closed
nickmccurdy opened this issue Apr 24, 2018 · 3 comments
Closed

Install task should be available by default in npm extension #48456

nickmccurdy opened this issue Apr 24, 2018 · 3 comments
Assignees
Labels
tasks Task system issues verified Verification succeeded
Milestone

Comments

@nickmccurdy
Copy link

It appears that as of 1420d41#r28075777, VSCode no longer provides an install task by default in its npm extension, making setting up new projects less convenient when there is no install hook in package.json (which applies to most packages).

  • VSCode Version: 1.22.2 and 1.23.0-insider
  • OS Version: macOS 10.13.4

Steps to Reproduce:

  1. Start a new project with a package.json file.
  2. Add a test script.
  3. Run Tasks: Run Build Task. Note that test is present, but install is not.
  4. Add an install script.
  5. Run Tasks: Run Build Task. Note that both install and test are present. VSCode now recognizes the built in install task because it thinks it's a custom script, when it's actually an npm install hook.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Apr 24, 2018

@vscodebot vscodebot bot added the tasks Task system issues label Apr 24, 2018
@dbaeumer dbaeumer assigned egamma and unassigned dbaeumer Apr 24, 2018
@egamma egamma added this to the April 2018 milestone Apr 26, 2018
@egamma
Copy link
Member

egamma commented Apr 26, 2018

Removed since a poll in the team gave that everybody is running install from the command line.
However, adding install doesn´t hurt.

egamma added a commit that referenced this issue Apr 26, 2018
@egamma egamma closed this as completed Apr 26, 2018
@dbaeumer dbaeumer added the verified Verification succeeded label Apr 27, 2018
@nickmccurdy
Copy link
Author

I just tried this out in Insiders and task install works great, thank you!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants