Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should experimental and nonstandard CSS properties have warning icon next to Read More icon? #48601

Closed
gregvanl opened this issue Apr 24, 2018 · 3 comments
Closed

Should experimental and nonstandard CSS properties have warning icon next to Read More icon? #48601

gregvanl opened this issue Apr 24, 2018 · 3 comments
Assignees
@octref
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone
Backlog

Comments

@gregvanl
Copy link

Users may not have the Read More flyout open while editing and might miss experimental and nonstandard warnings. Should the warning triangle and red siren icon be also shown next to the Read More blue icon?

Found during testing #48443
@octref octref added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Apr 26, 2018
@octref octref added this to the April 2018 milestone Apr 26, 2018
@octref
Copy link
Contributor

octref commented Apr 26, 2018

css

octref added a commit to microsoft/vscode-css-languageservice that referenced this issue Apr 26, 2018
@octref
Drop microsoft/vscode#48601
3102e76
@octref octref reopened this Apr 26, 2018
@octref octref modified the milestones: April 2018, Backlog Apr 26, 2018
@octref octref added the feature-request Request for new features or functionality label Apr 26, 2018
@octref
Copy link
Contributor

octref commented Apr 26, 2018

I've pulled it out because we have some concerns for the too bright emojis. Need to reconsider the UX.

octref added a commit that referenced this issue Apr 27, 2018
@octref
[css] update service to pull out #48601
b8f1bdb
@octref
Copy link
Contributor

octref commented Oct 5, 2018

Actually because many people use transpilers, these warnings won't be accurate. Let's forget about this then.

@octref octref closed this as completed Oct 5, 2018
@octref octref added the *out-of-scope Posted issue is not in scope of VS Code label Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@octref octref

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@octref @gregvanl