Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: highlight escaped javascript characters in default Light+ theme #48638

Closed
jeffreymeng opened this issue Apr 25, 2018 · 2 comments · Fixed by #48746
Closed

Feature request: highlight escaped javascript characters in default Light+ theme #48638

jeffreymeng opened this issue Apr 25, 2018 · 2 comments · Fixed by #48746
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities javascript JavaScript support issues themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2018

Comments

@jeffreymeng
Copy link

VS Code version: Code 1.22.2
OS version: MacOS High Sierra 10.13.4

In the dark+(Default dark) theme of vs code, escape sequences in javascript are highlighted:
2018-04-24_21-45-36

However, in the light+(Default light) theme, escape sequences on javascript are not highlighted:
2018-04-24_21-45-58

Is there a specific reason for this? If not, it would be nice to have highlighting added to the Light+ default theme.
@vscodebot
Copy link

vscodebot bot commented Apr 25, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the javascript JavaScript support issues label Apr 25, 2018
@jeffreymeng
Copy link
Author

This is completely different from #17533, just to be clear(I know it's experimental)

@mjbvz mjbvz added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality themes Color theme issues labels Apr 25, 2018
@Ikuyadeu Ikuyadeu mentioned this issue Apr 26, 2018
Merged
mjbvz pushed a commit that referenced this issue Apr 29, 2018
@Ikuyadeu @mjbvz
Highlight escaped characters in default Light+ (Fix #48638) (#48746)
11834f3 
* highlight escaped characters in default Light+(Fix #48638)

* fix constant.character.escape

* fix constant.character.escape again
@mjbvz mjbvz added this to the May 2018 milestone Apr 29, 2018
@mjbvz mjbvz mentioned this issue Apr 29, 2018
Closed
@mjbvz mjbvz added the verification-needed Verification of issue is requested label May 25, 2018
@isidorn isidorn added the verified Verification succeeded label May 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities javascript JavaScript support issues themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

Successfully merging a pull request may close this issue.

Highlight escaped characters in default Light+ (Fix #48638) Ikuyadeu/vscode
3 participants
@isidorn @mjbvz @jeffreymeng