Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge results from multiple DocumentHighlightProviders #48821

Open
martinlippert opened this issue Apr 27, 2018 · 8 comments
Open

Merge results from multiple DocumentHighlightProviders #48821

martinlippert opened this issue Apr 27, 2018 · 8 comments
Labels
editor-symbols definitions, declarations, references feature-request Request for new features or functionality
Milestone

Comments

@martinlippert
Copy link

as discussed in here:

microsoft/vscode-languageserver-node#318

I would love to see VS Code to support the document highlights from multiple extensions simultaneously, much in the same way hovers can be provided from multiple extensions and are displayed in the same hover popup.

The background for this is:
I have a language server based extension for VS Code that can deliver documentHighlight information for Java code, but as long as the Java language extension itself is installed and active, my documentHighlights are never shown (but the ones from the Java extension instead).

The purpose of my language server is to provide additional functionality for Java source code, not to replace the existing Java language tooling. Therefore I benefit from the ability to run multiple language servers for the same language (file type) and that the results from both are merged (which is the case for content assist and hover information, for example). I need the same mechanics for documentHighlight requests/responses... :-)

@vscodebot
Copy link

vscodebot bot commented Apr 27, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Apr 27, 2018
@dbaeumer
Copy link
Member

This is about providing this in general in our API. Unrelated to language servers.

@dbaeumer dbaeumer added api and removed extensions Issues concerning extensions labels Apr 27, 2018
@jrieken jrieken added editor-symbols definitions, declarations, references api under-discussion Issue is under discussion for relevance, priority, approach and removed api labels Apr 30, 2018
@jrieken
Copy link
Member

jrieken commented Apr 30, 2018

Understood. Making such a change might surprise some people tho. Unsure how we should proceed.

@dbaeumer
Copy link
Member

dbaeumer commented May 7, 2018

Good point

@jrieken jrieken assigned alexdima and unassigned jrieken Sep 11, 2018
@jrieken
Copy link
Member

jrieken commented Sep 11, 2018

Assigning @alexandrudima who owns the word highlight feature

@alexdima alexdima changed the title show documentHighlight information from multiple extensions Merge results from multiple DocumentHighlightProvider Sep 12, 2018
@alexdima alexdima added feature-request Request for new features or functionality editor-contrib Editor collection of extras and removed under-discussion Issue is under discussion for relevance, priority, approach api labels Sep 12, 2018
@alexdima alexdima added this to the Backlog milestone Sep 12, 2018
@alexdima alexdima changed the title Merge results from multiple DocumentHighlightProvider Merge results from multiple DocumentHighlightProviders Sep 12, 2018
@dbaeumer dbaeumer removed their assignment Oct 16, 2019
@alexdima alexdima removed the editor-contrib Editor collection of extras label Jan 23, 2020
@alexdima alexdima modified the milestones: Backlog, Backlog Candidates Jan 23, 2020
@vscodebot
Copy link

vscodebot bot commented Jan 23, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@alexdima alexdima removed their assignment Jan 23, 2020
@jrieken jrieken self-assigned this Jan 23, 2020
@kdvolder
Copy link

Making such a change might surprise some people tho

Perhaps, but probably it be a 'pleasant' surprise. I.e. something that wasn't working and ..surprise... suddenly it works :-)

@vscodebot
Copy link

vscodebot bot commented Jan 23, 2020

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot vscodebot bot modified the milestones: Backlog Candidates, Backlog Jan 23, 2020
@jrieken jrieken removed their assignment Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-symbols definitions, declarations, references feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants