Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to toggle between hiding or highlight find results #49922

Closed
jrieken opened this issue May 15, 2018 · 2 comments
Closed

Allow to toggle between hiding or highlight find results #49922

jrieken opened this issue May 15, 2018 · 2 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality on-testplan outline Source outline view issues
Milestone
June 2018

Comments

@jrieken
Copy link
Member

jrieken commented May 15, 2018 •
edited

The current outline allows to filter. However, there is a desire to not filter but to just highlight matching items. Likely that you want goto prev/next commands to honour only highlighted items tho

filter
screen shot 2018-05-15 at 19 03 38

highlight
webstorm_filter
@jrieken jrieken self-assigned this May 15, 2018
@jrieken jrieken added feature-request Request for new features or functionality outline Source outline view issues labels May 15, 2018
@jrieken jrieken added this to the June 2018 milestone Jun 8, 2018
jrieken added a commit that referenced this issue Jun 8, 2018
@jrieken
add setting to toggle between filter or find, #49922
ae31e8c
@jrieken
Copy link
Member Author

jrieken commented Jun 8, 2018

Will come with two settings

    "outline.filterOnType": true, // filter vs find
    "outline.navigateHighlights": true, // up/down skips elements that don't match

jrieken added a commit that referenced this issue Jun 8, 2018
@jrieken
add command and setting to navigate between highlighted elements only, …
83cec01 
…#49922
jrieken added a commit that referenced this issue Jun 8, 2018
@jrieken
use improved openView api, nuke singleton, #49922
9c3af12
jrieken added a commit that referenced this issue Jun 8, 2018
@jrieken
nuke setting and add control in input box, #49922
0f3c383
@jrieken
Copy link
Member Author

jrieken commented Jun 8, 2018

No more settings, but buttons. Maybe moving this to the ...-menu because the filter button hinders tab navigation

jun-08-2018 15-52-13

@jrieken jrieken closed this as completed Jun 8, 2018
jrieken added a commit that referenced this issue Jun 11, 2018
@jrieken
move filter/find action into overflow menu #49922
be4b47e
@jrieken jrieken mentioned this issue Jun 25, 2018
Closed
2 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality on-testplan outline Source outline view issues
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
1 participant
@jrieken