Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak DOM renderer condition #50130

Closed
Tyriar opened this issue May 18, 2018 · 3 comments
Closed

Tweak DOM renderer condition #50130

Tyriar opened this issue May 18, 2018 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
May 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented May 18, 2018

People are reporting they're seeing the notification to switch terminal renderers when they shouldn't

#50124
#50125
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels May 18, 2018
@Tyriar Tyriar added this to the May 2018 milestone May 18, 2018
@Tyriar Tyriar self-assigned this May 18, 2018
@Tyriar Tyriar mentioned this issue May 18, 2018
Closed
Tyriar added a commit that referenced this issue May 18, 2018
@Tyriar
Double DOM renderer suggestion time
28e770f 
Part of #50130
@Tyriar
Copy link
Member Author

Tyriar commented May 18, 2018

The first frame that was being measured turns out to normally take a lot longer than the others. I'm going to measure a bunch of frames, discard the first ones and check the average:

screen shot 2018-05-18 at 2 52 54 pm

@Tyriar Tyriar closed this as completed in b8a9da5 May 18, 2018
@octref octref added the verification-steps-needed Steps to verify are needed for verification label May 31, 2018
@octref
Copy link
Contributor

octref commented May 31, 2018

@Tyriar How can I verify it?

@Tyriar
Copy link
Member Author

Tyriar commented May 31, 2018

@octref code review is probably the best way

@Tyriar Tyriar removed the verification-steps-needed Steps to verify are needed for verification label May 31, 2018
@octref octref added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@Tyriar @octref