Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing API for knowing when an extension's decorations get trashed #50415

Closed
fabiospampinato opened this issue May 24, 2018 · 2 comments
Closed
Assignees
Labels
api feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code

Comments

@fabiospampinato
Copy link
Contributor

Todo+ makes heavy use of dynamic decorations.

It decorates the active document, if it's supported, on onDidChangeActiveTextEditor. As a performance optimization I wanted to skip the decoration logic if the document has already been decorated and its content didn't change.

I think this is impossible to implement because there's no way of knowing if the decorations your extension applied have been trashed or not, sometimes they do get trashed, sometimes they don't.

Fixing #50346 would also fix this issue, but they are not the exactly the same thing

@vscodebot
Copy link

vscodebot bot commented May 24, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jrieken jrieken assigned alexdima and unassigned jrieken May 29, 2018
@alexdima alexdima added feature-request Request for new features or functionality api labels May 29, 2018
@fabiospampinato fabiospampinato changed the title Missing API for knowing when yours decorations get trashed Missing API for knowing when an extension's decorations get trashed Aug 6, 2018
@alexdima alexdima added the *out-of-scope Posted issue is not in scope of VS Code label Oct 10, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants