Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text overflows split terminal when using dom renderer #51479

Closed
RMacfarlane opened this issue Jun 8, 2018 · 9 comments
Closed

Text overflows split terminal when using dom renderer #51479

RMacfarlane opened this issue Jun 8, 2018 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@RMacfarlane
Copy link
Contributor

Issue Type: Bug

Steps to reproduce:

  1. Set terminal.intergrated.rendererType to dom
  2. Split the terminal
  3. Run a command that will generate long lines that need to be wrapped, ex. ./scripts/code.sh in the vscode repo

The text runs over the edge into the next terminal:
screen shot 2018-06-08 at 11 02 56 am

VS Code version: Code - Insiders 1.25.0-insider (8f8ed32, 2018-06-08T05:10:42.592Z)
OS version: Darwin x64 17.4.0

@RMacfarlane RMacfarlane added the terminal Integrated terminal issues label Jun 8, 2018
@Tyriar Tyriar added this to the June 2018 milestone Jun 9, 2018
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jun 9, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 10, 2018

Another case: #51552

@Tyriar
Copy link
Member

Tyriar commented Jun 20, 2018

Resizing down doesn't trim the line ends:

screen shot 2018-06-20 at 7 44 23 pm

@Tyriar Tyriar closed this as completed in 341fc24 Jun 20, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Jun 27, 2018

I still see a slight visual overlap

screen shot 2018-06-27 at 2 14 51 pm

@DuncanFaulkner
Copy link

Seeing a similar issue in code-insiders (27" monitor not 4k), same version works fine on 22"
both on ubuntu 18.04 and 16.04 respectively.
Also only seems to affect terminal window all other command windows are fine.
vs screen shot

@Tyriar
Copy link
Member

Tyriar commented Jul 7, 2018

@DuncanFaulkner could you let us know if it's fixed in the next build? (it's out in next Insiders build on Monday morning PST)

@DuncanFaulkner
Copy link

Will check and let you know

@DuncanFaulkner
Copy link

Have just updated to version code-insiders_1.26.0-1530854541_amd64.deb and it's still doing it, will check tomorrow evening to see if that version has fixed the issue

@DuncanFaulkner
Copy link

@Tyriar yes that has appeared to fix the issue, thanks

@Tyriar
Copy link
Member

Tyriar commented Jul 9, 2018

Awesome, thanks for verifying 😃

@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants