The width of the terminal can overflow out of the panel for proportional fonts

[parthvakharia]

Issue Type: Bug

Open side by side integrated terminal the boundry of terminals are not properly allign it goes over side bar (my side bar is on right hand). The inner wall of terminals ae also overlaping fonts.

VS Code version: Code 1.25.1 (1dfc5e5, 2018-07-11T15:43:53.668Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-5500U CPU @ 2.40GHz (4 x 2394)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: disabled_software video_decode: enabled video_encode: enabled vpx_decode: unavailable_software webgl: enabled webgl2: enabled
Memory (System)	7.90GB (3.32GB free)
Process Argv	D:\Program Files (x86)\Microsoft VS Code\Microsoft VS Code\Code.exe
Screen Reader	no
VM	0%

Extensions (3)

Extension	Author (truncated)	Version
vscode-cosmosdb	ms-	0.8.0
azure-account	ms-	0.4.1
node-debug2	ms-	1.26.2

[wgwine]

I see the same on Mac.

[yume-chan]

Relates to #51945

Regression?

[Tyriar]

This is fixed in insiders #51479

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

[yume-chan]

@Tyriar Someone has confirmed it's fixed in a 7-day-ago version, but I think this guy is using... eh... a not-7-day-ago version.

And I can still reproduce it using my "invalid terminal font" repro.

[Tyriar]

@yume-chan hmm, I can't repro that on Linux using dom renderer+Arial. What font are you using?

Could you also try inspecting the terminal elements and take a screenshot of the spans in the row?

[yume-chan]

@Tyriar I'm using canvas renderer.

Steps to reproduce:

1. Set terminal.integrated.fontFamily to non-monospace font.
2. Close terminal panel and sidebar
3. Restart Code
4. Open sidebar
5. Open terminal panel

[Tyriar]

@yume-chan I can repro with those steps 👍

[Tyriar]

I don't think it's the issue the OP was seeing but let's track it here. #51945 was about monospace fonts

[Tyriar]

This would be fixed with the proposal in xtermjs/xterm.js#702 (comment)