Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed:generator method of class autocomplete causes star(*) to be add… #51557

Merged
merged 3 commits into from
Sep 11, 2018

Conversation

limerickgds
Copy link

@limerickgds limerickgds commented Jun 10, 2018

i add a onEnterRule rule that will only execute if the text above the this line matches /** or *.
but i don't think this is a good solution.
Fixes #43469
cc: @joaomoreno

@msftclas
Copy link

msftclas commented Jun 10, 2018

CLA assistant check
All CLA requirements met.

@limerickgds
Copy link
Author

@misolori do you need anything from me to merge this PR?

@miguelsolorio miguelsolorio removed their assignment Jul 6, 2018
@miguelsolorio
Copy link
Contributor

@limerickgds I'll let @aeschli handle this PR

@mjbvz mjbvz self-assigned this Jul 19, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Jul 19, 2018

@alexandrudima / @rebornix Can you please take a look at this

@limerickgds
Copy link
Author

@mjbvz @misolori @aeschli How long do I have to wait?

@aeschli
Copy link
Contributor

aeschli commented Jul 26, 2018

@alexandrudima and @rebornix have the final word here, but looking at the previous line looks fishy to me. For other language configurations we can already express where the rule applies:

	"autoClosingPairs": [
		{ "open": "/*", "close": "*/", "notIn": ["string"] },
		{ "open": "\"", "close": "\"", "notIn": ["string", "comment"] },
	]

See https://github.com/Microsoft/vscode/blob/7c03ce156505cca6c60bd5afd9b2f33f25ec64ad/src/vs/editor/common/modes/languageConfiguration.ts#L177.

Ideally, we can add the same for OnEnterRule

@limerickgds
Copy link
Author

@aeschli do you need i change this PR ?

@alexdima
Copy link
Member

I personally kind of like it that the implemention of onEnterRules is kept tokenization agnostic and I think the new rule (oneLineAboveText) is in the same spirit with my original implemention (i.e. similar to beforeText and afterText).

@limerickgds Thank you !

@alexdima alexdima merged commit 1026e5f into microsoft:master Sep 11, 2018
@alexdima alexdima added this to the September 2018 milestone Sep 11, 2018
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

src/vs/vscode.d.ts Show resolved Hide resolved
@jrieken
Copy link
Member

jrieken commented Sep 11, 2018

creates #58440 as tracking item

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generator method of class autocomplete causes star(*) to be added to next line
7 participants