-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed:generator method of class autocomplete causes star(*) to be add… #51557
Conversation
@misolori do you need anything from me to merge this PR? |
@limerickgds I'll let @aeschli handle this PR |
@alexandrudima / @rebornix Can you please take a look at this |
@alexandrudima and @rebornix have the final word here, but looking at the previous line looks fishy to me. For other language configurations we can already express where the rule applies:
Ideally, we can add the same for |
@aeschli do you need i change this PR ? |
I personally kind of like it that the implemention of @limerickgds Thank you ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
creates #58440 as tracking item |
i add a onEnterRule rule that will only execute if the text above the this line matches /** or *.
but i don't think this is a good solution.
Fixes #43469
cc: @joaomoreno