Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "snap to minimize/maximize" feature with grid editor layout #51614

Closed
martin-sweeny opened this issue Jun 11, 2018 · 8 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone

Comments

@martin-sweeny
Copy link

martin-sweeny commented Jun 11, 2018

  • VSCode Version: 1.25.0-insider
  • OS Version: Windows 7

Steps to Reproduce:

  1. Open 2 files
  2. Split panes
  3. Drag the panes so one is as small as possible
  4. Click that pane

Expected Result

The small pane, when clicked on, should expand to take as much space as possible, shrinking the other pane(s).

Actual Result

The pane stays small.


Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Jun 11, 2018

@bpasero bpasero changed the title Panes don't auto-expand anymore Restore "snap to minimize" feature with grid editor layout Jun 11, 2018
@bpasero bpasero added feature-request Request for new features or functionality workbench-editor-grid Grid layout issues in the editor area labels Jun 11, 2018
@bpasero bpasero removed their assignment Jun 11, 2018
@bpasero bpasero changed the title Restore "snap to minimize" feature with grid editor layout Restore "snap to minimize/maximize" feature with grid editor layout Jun 11, 2018
@bpasero
Copy link
Member

bpasero commented Jun 11, 2018

This came in when we moved to grid. @joaomoreno to comment how feasible it would be to restore this in the grid widget.

@benjaminblack
Copy link

benjaminblack commented Jul 6, 2018

Unpleasantly surprised to discover this feature gone in the stable release yesterday. Please bring this feature back. I used the three separate editor groups to organize assets by type (HTML, CSS, JS), and rapidly switching between them became a muscle memory.

In fact, I was so hopeful with the new grid layout, one of the first things I tried to do is create a four-up grid Hollywood-Squares-style, and see if the min/max behavior would work if I had one group expanded and the other three minimized horizontally and vertically. Alas, no.

bpasero added a commit that referenced this issue Jul 7, 2018
@bpasero bpasero closed this as completed in 61e0cf0 Jul 9, 2018
@bpasero bpasero self-assigned this Jul 9, 2018
@bpasero bpasero added the verification-needed Verification of issue is requested label Jul 9, 2018
@bpasero
Copy link
Member

bpasero commented Jul 9, 2018

Pushed a change to maximize a view in the grid that is either vertically or horizontally with minimal size.

@bpasero
Copy link
Member

bpasero commented Jul 15, 2018

Verify:

  • this works with any grid layout, once you make a view small enough that it hits its minimal size (either vertically or horizontally), clicking into that view will minimize all others

@benjaminblack
Copy link

benjaminblack commented Jul 24, 2018

Thank you! Works brilliantly with the grid layout system.

@JacksonKearl JacksonKearl added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jul 31, 2018
@lsps9150414
Copy link

@bpasero May I ask if the feature is released in 1.25.1? My view is not expanded when focused
8 -12-2018 12-52-04

@bpasero
Copy link
Member

bpasero commented Aug 12, 2018

@lsps9150414 no, July is 1.26. But you can stop waiting for stable releases and start using our nightly releases where this fix already landed: You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

6 participants
@bpasero @martin-sweeny @lsps9150414 @benjaminblack @JacksonKearl and others