Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet does not work inside script tag with type="text/ng-template" #51768

Closed
jwhitmarsh opened this issue Jun 13, 2018 · 2 comments
Closed

Emmet does not work inside script tag with type="text/ng-template" #51768

jwhitmarsh opened this issue Jun 13, 2018 · 2 comments
Assignees
Labels
emmet Emmet related issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Milestone

Comments

@jwhitmarsh
Copy link
Contributor

This is identical to #34921 but for "text/ng-template"

Emmet expansion (via Tab, or via Command Palette) doens't work on text inside a <script> tag with this type. These tags are used in AngularJS for templates - https://docs.angularjs.org/api/ng/directive/script

  • VSCode Version: Version 1.24.0 (1.24.0)
  • OS Version: macOS 10.12.6

Steps to Reproduce:

  1. Create an HTML file like this:
<script type="text/ng-template">
  
</script> 
  1. Write an emmet string inside the script tag and press Tab/use command palette to trigger expansion. Nothing happens.
<script type="text/ng-template">
div>p  
</script> 
  1. Write an emmet string inside the script tag and press Tab/use command palette to trigger expansion. It works.
<script type="text/ng-template">

</script> 
div>p

Does this issue occur when all extensions are disabled?: Yes

@jwhitmarsh
Copy link
Contributor Author

Am I right in thinking that adding "text/ng-template" in the line below would solve this? Is that a satisfactory fix?

https://github.com/Microsoft/vscode/blob/ae9063f0944adb9e4711b033c5790d87c6ba4e4f/extensions/emmet/src/util.ts#L50

@RMacfarlane RMacfarlane added the emmet Emmet related issues label Jun 13, 2018
@vscodebot vscodebot bot removed the new release label Jun 13, 2018
@ramya-rao-a
Copy link
Contributor

@jwhitmarsh Yes, that would fix it. Feel free to send a PR :)

@ramya-rao-a ramya-rao-a added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality labels Jun 13, 2018
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jun 13, 2018
jwhitmarsh pushed a commit to jwhitmarsh/vscode that referenced this issue Jun 14, 2018
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, June 2018 Jun 22, 2018
@ramya-rao-a ramya-rao-a added the verification-needed Verification of issue is requested label Jun 22, 2018
@miguelsolorio miguelsolorio added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jun 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants