settings editor has different fontSize

[shizengzhou]

Issue Type: Bug

1. Open settings editor
2. Change "editor.fontSize"
   The font size on the right part of settings editor sometimes is not changed.
   

VS Code version: Code - Insiders 1.25.0-insider (7dc9539, 2018-06-15T05:12:05.222Z)
OS version: Darwin x64 17.6.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-5250U CPU @ 1.60GHz (4 x 1600)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	8.00GB (0.09GB free)
Process Argv	/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_229432
Screen Reader	no
VM	0%

Extensions (7)

Extension	Author (truncated)	Version
vscode-eslint	dba	1.4.12
gitlens	eam	8.3.5
EditorConfig	Edi	0.12.4
tslint	eg2	1.0.32
debugger-for-chrome	msj	4.6.0
vscode-icons	rob	7.23.0
open-in-browser	tec	1.1.0

(2 theme extensions excluded)

[roblourens]

I can repro but I don't know what would cause this.

@sandy081 @rebornix ?

[sandy081]

Definitely regression in insiders. I can confirm the updates are being passed to code editor widget.

[rebornix]

I ran into issue the very moment I tried to verify it, but after that I can no longer reproduce. Would love to see any stable reproduce steps.

[roblourens]

Maybe it's only in the first instance of the settings editor open during a vscode session. After I close the settings editor and reopen it, it works correctly.

[rebornix]

@roblourens thanks, that's exactly it.

[vscodebot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[Nikki1993]

What kind of additional information would you require @roblourens? I am running into the same problem now on Arch Linux where changing font size in user settings does not update the font size on the fly until full reload.

P.S. to clarify, the issue only affects User Settings window. Default User Settings and any other editor window is not affected.

[rebornix]

Dig into it and found the root cause, the reason is the very first time the editor being opened, we try to set the editor to visible by

https://github.com/Microsoft/vscode/blob/5dec58794d15d735e7fb1821625d810e818ccc34/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts#L901-L908

However, if the preference editor is opened the first time, the editablePreferencesEditor is still undefined so we can't mark it as visible. And then the next time when the configuration event kicks in, the editablePreferencesEditor is still invisible (even though we can see it) so no re-render is triggered.

I don't know how to manage the lifecycle of the Preference editor, assign back to @roblourens for now but I still keep an eye on it.

[roblourens]

Thanks for the investigation. I'm not too worried about the JSON editor anymore but I see an easy fix so I'll fix this one.

[sandy081]

I can look for an easy fix.

[roblourens]

I fixed it and didn't push the commit, sorry