Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: on focus announce up / down arrows are used for navigation #52658

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 22, 2018 · 4 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues extensions Issues concerning extensions under-discussion Issue is under discussion for relevance, priority, approach windows VS Code on Windows issues
Milestone

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10

Additional Details:
ScreenReader Version: NVDA2018.2

Repro Steps:

  1. Launch VS Code while NVDA is ON.
  2. Go to View menu and Select Extensions
  3. Type something in the Search textbox, and press tab key

Actual:
NVDA does not read instructions for navigating inside the treeview.

Expected:
When the focus is on treeview, NVDA should read use up/down arrow keys to navigate inside the treeview.

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
User might face problem in navigating inside the treeview if screenreader would announce the instructions.

Attachment for Reference:
A11y VSCode Usability Extensions missing instructions.pptx

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Jun 22, 2018
@chrmarti chrmarti added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 22, 2018
@isidorn isidorn changed the title [Accessibility][Usability]A11y_VSCode_ViewExtensions_ScreenReader: Instructions are missing to navigate inside the treeview. Tree: on focus announce up / down arrows are used for navigation Jul 5, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 5, 2018

Disagree. We use the same navigation in all our trees across the workbench.
Though assigning to @joaomoreno to consider announcing that up/down are used for navigation whenever tree gets focus. IMHO this is superflous

@isidorn isidorn assigned joaomoreno and unassigned sandy081 Jul 5, 2018
@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Jul 5, 2018
@joaomoreno joaomoreno added this to the July 2018 milestone Jul 5, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 19, 2018

@joaomoreno I see you have tackled this only for the extensions view? Should we do it for all other views as well?

@joaomoreno
Copy link
Member

Pushed one more commit.

joaomoreno added a commit that referenced this issue Jul 19, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 2, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues extensions Issues concerning extensions under-discussion Issue is under discussion for relevance, priority, approach windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

5 participants