Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use exceptions for missing grammars #52692

Closed
alexdima opened this issue Jun 22, 2018 · 1 comment
Closed

Do not use exceptions for missing grammars #52692

alexdima opened this issue Jun 22, 2018 · 1 comment
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2018

Comments

@alexdima
Copy link
Member

alexdima commented Jun 22, 2018 •
edited

  • Open VS Code Stable
  • Open developer tools
  • Configure to break on caught exceptions
  • Open a .md file
  • Observe: No exceptions
  • do the same in VS Code Insiders
  • there is an exception in resolveContent. I have mitigated that, but there are still 13 exceptions occurring inside vscode-textmate.

Please do not use exceptions in cases where a missing grammar is one of two expected outcomes.
@alexdima alexdima added this to the June 2018 milestone Jun 22, 2018
aeschli added a commit to microsoft/vscode-textmate that referenced this issue Jun 22, 2018
@aeschli
Do not use exceptions for missing grammars. For microsoft/vscode#52692
07612b6
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Jun 26, 2018
@alexdima
Copy link
Member Author

Thank you! ❤️

@alexdima alexdima added the verified Verification succeeded label Jun 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
2 participants
@alexdima @aeschli