Custom menus follow up

[bpasero]

Some follow up from code review that I consider more debt and not bugs which is fine to look at for July:

• remove the titlebarPart.css transition rule unless there is a need for it
  Looks like it is being used (Make titlebar more consistent with Windows 10 #53211 (comment))
• remove the old menu implementation
  • verify everything works as before when menu is not custom and on macOS
• remove the vscode.toggleAutoSave which I think is no longer needed then
• remove FILE_MENU_FAKE_OPEN_FILE_COMMAND_ID ?
• why are there two AlternativeKeyEmitter (here, here), can they not be reused/shared?
• what is the purpose of the resizer element in the title bar part?
• why are the window buttons called chrome-xy? google chrome?
• do not use a querySelect to find the element, rather keep it as field
• menubarPart is should use the builder pattern either fully or not, but partially is a bit weird, e.g. this.customMenus[menuIndex].titleElement.getHTMLElement().onmouseenter vs. this.customMenus[menuIndex].titleElement.on(EventType.CLICK, (event) => {
• menubarPart is not properly cleaning up disposeables, for example this:

this.configurationService.onDidChangeConfiguration(e => this.onConfigurationUpdated(e));

should be

this._register(this.configurationService.onDidChangeConfiguration(e => this.onConfigurationUpdated(e)));

[sbatten]

@bpasero

why are there two AlternativeKeyEmitter (here, here), can they not be reused/shared

I originally created the second one because the original was used for the alternative actions throughout the workbench, but that behavior was still under discussion. Now, I've modified it by quite a bit to fit my needs and changed the name even.

what is the purpose of the resizer element in the title bar part?

On windows, the window can't be resized from a draggable region, so the resizer let's you grab from the top.

why are the window buttons called chrome-xy? google chrome?

UI jargon, that stuffs called window chrome.

[bpasero]

@sbatten I think for this we are now down to deleting the old menu implementation