Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: "Select All" does not work in input fields #52948

Closed
bpasero opened this issue Jun 26, 2018 · 3 comments
Closed

Menu: "Select All" does not work in input fields #52948

bpasero opened this issue Jun 26, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 26, 2018

Refs: #52854

Steps:

  • click into an input field (e.g. search viewlet)
  • right click
  • pick "Select All"

=> 馃悰 nothing is selected

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-menu labels Jun 26, 2018
@bpasero bpasero added this to the June 2018 milestone Jun 26, 2018
@bpasero
Copy link
Member Author

bpasero commented Jun 26, 2018

I wonder if this is just a focus issue where after clicking "Select All" the input field was just not focused and so I could not see the selection?

@sbatten
Copy link
Member

sbatten commented Jun 26, 2018

If an editor is open when trying this repro, the action runs on the editor so we need a way to return focus before the action is run. I can do that in the action runner that I am already using if you know how I can track what was previously focused.

@bpasero bpasero assigned bpasero and unassigned sbatten Jun 27, 2018
@bpasero
Copy link
Member Author

bpasero commented Jun 27, 2018

I got a fix I think.

@bpasero bpasero closed this as completed Jun 27, 2018
bpasero added a commit that referenced this issue Jun 27, 2018
@Tyriar Tyriar added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants