Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings editor looks cramped #53111

Closed
sandy081 opened this issue Jun 27, 2018 · 8 comments
Closed

Settings editor looks cramped #53111

sandy081 opened this issue Jun 27, 2018 · 8 comments
Assignees
Labels
settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 27, 2018

Testing #52859

image

Content should proportionally expand with the size of the editor, otherwise lot of space on the left and right seems unused

@roblourens
Copy link
Member

roblourens commented Jun 27, 2018

On the other hand, people don't like to read a line of text that goes across a very wide screen. That's the main reason for the max-width. And how wide do the input boxes need to be? I can use more space but it wouldn't be used productively.

@sandy081
Copy link
Member Author

sandy081 commented Jun 27, 2018

Why not increase/decrease it in proportionate to the size of the editor. This is the style we follow in editors too. It scales pretty well. Its good to see well distributed content rather than empty space.

kapture 2018-06-27 at 22 00 07

@sandy081 sandy081 reopened this Jun 27, 2018
@roblourens
Copy link
Member

I think extremely long lines and text boxes don't look better than empty space.

Thoughts @misolori?

@roblourens roblourens added settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach labels Jun 28, 2018
@roblourens
Copy link
Member

image

@miguelsolorio
Copy link
Contributor

I think that we can strike a balance of using the space adequately while still remaining readable. I would also argue that reading code is a very different task than reading description text for a setting, so I wouldn't remove the max-width.

I'd suggest that for larger screens we increase the max-width to 1100px and increase the margin-right of the toc to 60px:

image

@roblourens
Copy link
Member

Changed it so the space between the TOC and settings list will shrink first, then the settings list will shrink, then the TOC will hide.

@sandy081
Copy link
Member Author

Yes, we do not need to make lines and input boxes long, we can give space between TOC and Contents. Above screen shot from @misolori looks perfect to me.

@roblourens
Copy link
Member

Lots of layout changes have happened, hope this is better now.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants