Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot assign to read only property 'enabled' of object '#<Object>' #53152

Closed
vscodeerrors opened this issue Jun 27, 2018 · 5 comments
Closed

Cannot assign to read only property 'enabled' of object '#<Object>' #53152

vscodeerrors opened this issue Jun 27, 2018 · 5 comments
Assignees
@alexdima
Labels
candidate Issue identified as probable candidate for fixing in the next release error-telemetry VS Code - Issues generated by telemetry verified Verification succeeded
Milestone
June 2018

Comments

@vscodeerrors
Copy link

Issue Id: 579d7b1f-9f9c-2f59-c541-8b03166dc623

Versions
- 1.25.0-insider (6/25/2018 9:37:32 AM)
Stack
TypeError: Cannot assign to read only property 'enabled' of object '#'
/vs/base/common/objects.ts#107:25
at Array.forEach (native)
/vs/base/common/objects.ts#101:22 (mixin)
/vs/base/common/objects.ts#105:6
at Array.forEach (native)
/vs/base/common/objects.ts#101:22 (mixin)
/vs/editor/browser/widget/embeddedCodeEditorWidget.ts#57:10 (updateOptions)
/vs/workbench/parts/debug/electron-browser/debugEditorContribution.ts#295:15 (_applyHoverConfiguration)
/vs/workbench/parts/debug/electron-browser/debugEditorContribution.ts#265:8 (call)
/vs/base/common/event.ts#140:15 (fire)
/vs/editor/browser/widget/codeEditorWidget.ts#387:25 (setModel)
/vs/editor/contrib/referenceSearch/referencesWidget.ts#810:18 (onComplete)
/vs/base/common/winjs.base.js#1581:0 (then)
/vs/editor/contrib/referenceSearch/referencesWidget.ts#794:64
/vs/base/common/winjs.base.js#10:0
/vs/base/common/winjs.base.js#10:0
@vscodeerrors
Copy link
Author

Here is another similar callstack

TypeError: Cannot assign to read only property 'enabled' of object '#'
/vs/base/common/objects.ts#107:25
at Array.forEach (native)
/vs/base/common/objects.ts#101:22 (mixin)
/vs/base/common/objects.ts#105:6
at Array.forEach (native)
/vs/base/common/objects.ts#101:22 (mixin)
/vs/editor/common/config/commonEditorConfig.ts#187:29 (updateOptions)
/vs/editor/browser/widget/codeEditorWidget.ts#337:22 (call)
/vs/editor/browser/widget/embeddedCodeEditorWidget.ts#52:21 (_onParentConfigurationChanged)
/vs/editor/browser/widget/embeddedCodeEditorWidget.ts#44:95 (call)
/vs/base/common/event.ts#140:15 (fire)
/vs/editor/browser/widget/codeEditorWidget.ts#227:34 (call)
/vs/base/common/event.ts#140:15 (fire)
/vs/editor/common/config/commonEditorConfig.ts#113:21 (_recomputeOptions)
/vs/editor/common/config/commonEditorConfig.ts#189:7 (updateOptions)
/vs/editor/browser/widget/codeEditorWidget.ts#337:22

@ramya-rao-a ramya-rao-a assigned alexdima and unassigned weinand Jun 27, 2018
@ramya-rao-a ramya-rao-a added the error-telemetry VS Code - Issues generated by telemetry label Jun 27, 2018
@microsoft microsoft deleted a comment from vscodeerrors Jun 27, 2018
@alexdima alexdima added this to the June 2018 milestone Jun 27, 2018
@alexdima alexdima mentioned this issue Jun 28, 2018
Closed
@bpasero
Copy link
Member

bpasero commented Jul 3, 2018

@alexandrudima I just got this stack in the insiders build from yesterday:

 ERR Cannot assign to read only property 'enabled' of object '#<Object>': TypeError: Cannot assign to read only property 'enabled' of object '#<Object>'
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:112:818
    at Array.forEach (native)
    at o (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:112:733)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:112:799
    at Array.forEach (native)
    at Object.o [as mixin] (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:112:733)
    at t.updateOptions (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1921:579)
    at e._applyHoverConfiguration (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4643:408)

image

@alexdima
Copy link
Member

alexdima commented Jul 3, 2018 •
edited

As this might be the cause of #52950, we should investigate for june.

@bpasero Do you have any steps? I think this is caused by calling updateOptions repeatedly and passing hover objects that are frozen from the configuration service.

image

@alexdima alexdima reopened this Jul 3, 2018
@alexdima alexdima added the candidate Issue identified as probable candidate for fixing in the next release label Jul 3, 2018
@alexdima
Copy link
Member

alexdima commented Jul 3, 2018

Possible steps to reproduce. (There might be other steps):

  • have side by side a .js file and the user settings.json
  • in the user settings.json write "editor.hover.enabled": false
  • reload workbench
  • in the .js file begin debugging
  • in the .js file stop debugging
  • comment out the setting in the settings side editor
 ERR Cannot assign to read only property 'enabled' of object '#<Object>': TypeError: Cannot assign to read only property 'enabled' of object '#<Object>'
    at file:///Users/alex/src/vscode/out/vs/base/common/objects.js:101:46
    at Array.forEach (native)
    at mixin (file:///Users/alex/src/vscode/out/vs/base/common/objects.js:94:33)
    at file:///Users/alex/src/vscode/out/vs/base/common/objects.js:98:29
    at Array.forEach (native)
    at Object.mixin (file:///Users/alex/src/vscode/out/vs/base/common/objects.js:94:33)
    at Configuration.CommonEditorConfiguration.updateOptions (file:///Users/alex/src/vscode/out/vs/editor/common/config/commonEditorConfig.js:142:40)
    at CodeEditorWidget.updateOptions (file:///Users/alex/src/vscode/out/vs/editor/browser/widget/codeEditorWidget.js:185:33)
    at TextFileEditor.BaseTextEditor.updateEditorConfiguration (file:///Users/alex/src/vscode/out/vs/workbench/browser/parts/editor/textEditor.js:242:36)
    at TextFileEditor.BaseTextEditor.handleConfigurationChangeEvent (file:///Users/alex/src/vscode/out/vs/workbench/browser/parts/editor/textEditor.js:69:22)
    at file:///Users/alex/src/vscode/out/vs/workbench/browser/parts/editor/textEditor.js:43:109
    at Emitter.fire (file:///Users/alex/src/vscode/out/vs/base/common/event.js:148:38)
    at file:///Users/alex/src/vscode/out/vs/editor/common/services/resourceConfigurationImpl.js:36:135
    at Emitter.fire (file:///Users/alex/src/vscode/out/vs/base/common/event.js:148:38)
    at WorkspaceService.triggerConfigurationChange (file:///Users/alex/src/vscode/out/vs/workbench/services/configuration/node/configurationService.js:550:48)
    at WorkspaceService.onUserConfigurationChanged (file:///Users/alex/src/vscode/out/vs/workbench/services/configuration/node/configurationService.js:422:18)
    at file:///Users/alex/src/vscode/out/vs/workbench/services/configuration/node/configurationService.js:53:105
    at Emitter.fire (file:///Users/alex/src/vscode/out/vs/base/common/event.js:148:38)
    at file:///Users/alex/src/vscode/out/vs/platform/configuration/node/configuration.js:34:136
    at Emitter.fire (file:///Users/alex/src/vscode/out/vs/base/common/event.js:148:38)
    at file:///Users/alex/src/vscode/out/vs/base/node/config.js:151:53
    at file:///Users/alex/src/vscode/out/vs/base/node/config.js:78:24
    at /Users/alex/src/vscode/node_modules/graceful-fs/graceful-fs.js:78:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (original-fs.js:439:3)

alexdima added a commit that referenced this issue Jul 3, 2018
@alexdima
Fixes #53152
b39d95a
@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2018

Nice steps, can not repro with latest insiders -> verified

@isidorn isidorn added the verified Verification succeeded label Jul 4, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
candidate Issue identified as probable candidate for fixing in the next release error-telemetry VS Code - Issues generated by telemetry verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
6 participants
@bpasero @weinand @isidorn @alexdima @vscodeerrors @ramya-rao-a