You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ramya-rao-a just to make sure this will work correctly in all cases:
there is no problem of having zh-hans or zh-hant in the extension name
the language id must always be zh-cn or zh-tw. These ids are API (extension might rely on it) and we can't change them. These are also the value returned from the Electron OS call to get the app locale.
are OK iff the language pack defined a id. If not (which we could argue should not happen) the code might not work since we should use the locale and not the currentLocale.
@ramya-rao-a This broke the recommendation prompts as the change is using the mapped locale id for getting minimal translations.
As @dbaeumer mentioned, we should use zh-hans or zh-hant only for extension names and locales should be always zh-cn and zh-tw. Pushed a fix for this here - 3962b54
Issue Type: Bug
Changing the display language to
zh-CN
orzh-Hant
doesn't show display language in Chinese and no prompt for language pack installation suggestion.zh-CN
andzh-Hant
works in latest Stable.VS Code version: Code - Insiders 1.25.0-insider (07d89ab, 2018-06-28T05:19:16.448Z)
OS version: Windows_NT x64 10.0.17134
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Extensions (6)
(1 theme extensions excluded)
The text was updated successfully, but these errors were encountered: