Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.monaco-workbench dependency #54030

Closed
jrieken opened this issue Jul 11, 2018 · 1 comment
Closed

.monaco-workbench dependency #54030

jrieken opened this issue Jul 11, 2018 · 1 comment
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Milestone
July 2018

Comments

@jrieken
Copy link
Member

jrieken commented Jul 11, 2018

When my context view element isn't declaring the monaco-workbench-class many things look bad, e.g. the font isn't proper, the sizing and alignment doesn't work etc. Searching for .monaco-workbench reveals 1201 matches and I don't know if all are justified.
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues labels Jul 11, 2018
@joaomoreno joaomoreno added this to the July 2018 milestone Jul 11, 2018
@joaomoreno joaomoreno mentioned this issue Jul 11, 2018
Closed
@joaomoreno
Copy link
Member

@jrieken The context view now lives inside monaco-workbench.

@joaomoreno joaomoreno mentioned this issue Jul 11, 2018
Closed
jrieken added a commit that referenced this issue Jul 11, 2018
@jrieken
remove unused class, #54030
a4b4d53
@JacksonKearl JacksonKearl added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @JacksonKearl