Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting checkbox label should be clickable #54053

Closed
joaomoreno opened this issue Jul 11, 2018 · 3 comments
Closed

Setting checkbox label should be clickable #54053

joaomoreno opened this issue Jul 11, 2018 · 3 comments
Assignees
@roblourens @cleidigh
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues ux User experience issues verified Verification succeeded
Milestone
August 2018

Comments

@joaomoreno
Copy link
Member

screenshot from 2018-07-11 15-43-12

Like this codepen: https://codepen.io/anon/pen/QBwOGj
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug ux User experience issues settings-editor VS Code settings editor issues labels Jul 11, 2018
@roblourens roblourens added this to the July 2018 milestone Jul 12, 2018
@roblourens roblourens modified the milestones: July 2018, August 2018 Aug 2, 2018
@roblourens roblourens mentioned this issue Aug 4, 2018
Closed
38 tasks
@roblourens roblourens mentioned this issue Aug 18, 2018
Closed
@cleidigh
Copy link
Contributor

@roblourens

I can pick this up since is directly related to the labeling I'm already doing..

@cleidigh cleidigh self-assigned this Aug 20, 2018
@cleidigh
Copy link
Contributor

cleidigh commented Aug 22, 2018 •
edited

@roblourens
@joaomoreno
started to work on this.
unless I'm really off-base, I don't think the simple HTML label as suggested will work as the checkbox widget implements the control as a custom element, not an HTML checkbox.

I think we have to make the entire text a clickable element that toggles the checkbox. I guess the other nested links can continue to activate their own targets.

Do you guys agree with the above?

@roblourens
Copy link
Member

Yes I think so

cleidigh added a commit to cleidigh/vscode that referenced this issue Aug 23, 2018
@cleidigh
Settings: Allow description to toggle checkbox Fixes: microsoft#54053
74693be
@bpasero bpasero added the verified Verification succeeded label Aug 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@cleidigh cleidigh

Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
August 2018
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @bpasero @cleidigh