Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb: show workspace folder #54370

Closed
bpasero opened this issue Jul 16, 2018 · 1 comment
Closed

Breadcrumb: show workspace folder #54370

bpasero opened this issue Jul 16, 2018 · 1 comment
Assignees
@jrieken
Labels
breadcrumbs polish Cleanup and polish issue
Milestone
July 2018

Comments

@bpasero
Copy link
Member

bpasero commented Jul 16, 2018

Steps to Reproduce:

  1. disable tabs
  2. enable breadcrumb

I think the breadcrumb should not start with a leading "/":

image

People could confuse this with an absolute path otherwise.
@bpasero bpasero added polish Cleanup and polish issue breadcrumbs labels Jul 16, 2018
@bpasero
Copy link
Member Author

bpasero commented Jul 16, 2018

Related: in a multiroot workspace, we actually show the workspace folder the file belongs to as the root:

image

I think we could restore this behaviour for breadcrumbs as well and simply trigger quick open when you click there?

@jrieken jrieken added this to the July 2018 milestone Jul 16, 2018
jrieken added a commit that referenced this issue Jul 16, 2018
@jrieken
don't show separator on first part of relative path, #54370
e155fdc
@jrieken jrieken changed the title Breadcrumb: show relative paths without leading "/" Breadcrumb: show workspace folder Jul 18, 2018
@jrieken jrieken closed this as completed Jul 24, 2018
jrieken added a commit that referenced this issue Jul 24, 2018
@jrieken
use FileKind in FileElement, #54370
cf27882
jrieken added a commit that referenced this issue Jul 24, 2018
@jrieken
add workspace folders to model and picker #54370
d406fc4
jrieken added a commit that referenced this issue Jul 24, 2018
@jrieken
add special rendering for no-tabs case, #54370
70b3e11
@chpxu chpxu mentioned this issue Aug 8, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
breadcrumbs polish Cleanup and polish issue
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
2 participants
@bpasero @jrieken