Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Accessibility Options" from help title bar #55451

Closed
mjbvz opened this issue Jul 31, 2018 · 2 comments
Closed

Remove "Accessibility Options" from help title bar #55451

mjbvz opened this issue Jul 31, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jul 31, 2018

Testing #55389

Issue Type: Bug

  1. Enable custom title bar
  2. Click on help

Bug
Notice entry for Accessibility Options. My understanding is that this is a command for internal use and should generally not be used by users

@alexandrudima Says we can remove the entire Accessibility Options command so that it no longer shows up in the command palette either

VS Code version: Code - Insiders 1.26.0-insider (0707dd4, 2018-07-31T05:18:06.861Z)
OS version: Windows_NT x64 10.0.17686

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (4 x 2195)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: unavailable_software
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 3.98GB (1.25GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader no
VM 57%
@alexdima
Copy link
Member

👍 We can just remove it if it bothers people. We only had it in insiders and used it as a critical Electron workaround for electron/electron#7208.

@sbatten sbatten added this to the July 2018 milestone Jul 31, 2018
@sbatten sbatten closed this as completed in 560724f Aug 1, 2018
mjbvz added a commit that referenced this issue Aug 2, 2018
@joaomoreno
Copy link
Member

@sbatten Added bug label.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug workbench-menu labels Aug 3, 2018
@mjbvz mjbvz added the verified Verification succeeded label Aug 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants