Fix bug causing an aria alert to not be shown the third time #55542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and odd numbers thereafter)
vikaskyadav
approved these changes
Aug 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and odd numbers thereafter)
Closes #27655.
It seems the screen reader will not read the same alert text twice. We get around that by incrementing the number of times seen and using that as part of the text.
The previous implementation attempted to get around this by flip/flopping between
msgandmsg (occurred again)as the message text. However, this doesn't work because themsgwould never get read after the first time. This is probably a bug in NVDA.