Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug causing an aria alert to not be shown the third time #55542

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Fix bug causing an aria alert to not be shown the third time #55542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
703b916
Fix bug causing an aria alert to not be shown the third time
Aug 1, 2018
c9cfac6
reset counter on new label
Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/vs/base/browser/ui/aria/aria.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,27 @@ export function status(msg: string): void {
}
}

let repeatedTimes = 0;
let prevText: string | undefined = undefined;
function insertMessage(target: HTMLElement, msg: string): void {
if (!ariaContainer) {
// console.warn('ARIA support needs a container. Call setARIAContainer() first.');
return;
}
if (target.textContent === msg) {
msg = nls.localize('repeated', "{0} (occurred again)", msg);

if (prevText === msg) {
repeatedTimes++;
}
else {
prevText = msg;
repeatedTimes = 0;
}


switch (repeatedTimes) {
case 0: break;
case 1: msg = nls.localize('repeated', "{0} (occurred again)", msg); break;
default: msg = nls.localize('repeatedNtimes', "{0} (occurred {1} times)", msg, repeatedTimes); break;
}

dom.clearNode(target);
Expand Down