Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html] Add wrap_attributes_indent_size and aligned-multiple options #55743

Closed
aeschli opened this issue Aug 3, 2018 · 2 comments
Closed

[html] Add wrap_attributes_indent_size and aligned-multiple options #55743

aeschli opened this issue Aug 3, 2018 · 2 comments
Assignees
@aeschli
Labels
feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2018

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 3, 2018

jsbeautify has new options wrap_attributes_indent_size and aligned-multiple options.

There's also a new proposal beautifier/js-beautify#1404 to reorganize all these settings.
@aeschli aeschli added this to the August 2018 milestone Aug 3, 2018
@aeschli aeschli self-assigned this Aug 3, 2018
@aeschli aeschli added the html HTML support issues label Aug 3, 2018
@aeschli aeschli mentioned this issue Aug 3, 2018
Closed
@aeschli aeschli added the feature-request Request for new features or functionality label Aug 3, 2018
@aeschli aeschli added the verification-needed Verification of issue is requested label Aug 27, 2018
@aeschli aeschli closed this as completed Aug 27, 2018
aeschli added a commit that referenced this issue Aug 27, 2018
@aeschli
[html] Add wrap_attributes_indent_size and aligned-multiple options.
112f31a 
Fixes #55743
@sandy081 sandy081 added verified Verification succeeded verification-steps-needed Steps to verify are needed for verification and removed verified Verification succeeded labels Aug 29, 2018
@sandy081
Copy link
Member

@aeschli What are the steps to verify this?

@aeschli
Copy link
Contributor Author

aeschli commented Aug 30, 2018

To verify:

  • create a html snippet with an element that has many attributes
  • change the wrap line length to something small
  • format and observe how the attributes are differently aligned with the various settings for 'html.format.wrapAttributes`

aligned-multiple adds as many attributes on the same line as possible, and aligns nicely after breaking the line.

I'll remove 'wrap_attributes_indent_size'. I don't know really what it does.

@bpasero bpasero removed the verification-steps-needed Steps to verify are needed for verification label Aug 30, 2018
aeschli added a commit that referenced this issue Aug 30, 2018
@aeschli
remove wrapAttributesIndentSize from settings for now (for #55743)
9d33073
@bpasero bpasero added the verified Verification succeeded label Aug 30, 2018
roblourens added a commit that referenced this issue Sep 11, 2018
@roblourens
Show HTML setting descriptions as markdown, remove wrapAttributesInde…
60b4b99 
…ntSize from #55743
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2018
Development

No branches or pull requests
3 participants
@bpasero @aeschli @sandy081