Fix bug causing workspace recommendations to go away upon ignoring a recommendation #55805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Aug 6, 2018
| @@ -801,7 +801,7 @@ export class WorkspaceRecommendedExtensionsView extends ExtensionsListView { | |||
| } | |||
|
|
|||
| async show(query: string): Promise<IPagedModel<IExtension>> { | |||
| let model = await ((query && query.trim() !== '@recommended') ? this.showEmptyModel() : super.show(this.recommendedExtensionsQuery)); | |||
| let model = await (/@recommended/.test(query) ? super.show(this.recommendedExtensionsQuery) : this.showEmptyModel()); | |||
There was a problem hiding this comment.
In the scenario which we are trying to fix, what is the value of query?
There was a problem hiding this comment.
@recommended:workspace
There was a problem hiding this comment.
We wouldn't want the WorkspaceRecommendedExtensionsView to run its query in case of say @recommended Go. So the right fix here would be `query && query.trim() !== '@recommended' && query.trim() !== '@recommended:workspace'
JacksonKearl
force-pushed
the
workspace-vanish-on-ignore
branch
from
ad7fb87
to
fbc6a8b
Compare
ramya-rao-a
reviewed
Aug 6, 2018
| @@ -801,7 +801,8 @@ export class WorkspaceRecommendedExtensionsView extends ExtensionsListView { | |||
| } | |||
|
|
|||
| async show(query: string): Promise<IPagedModel<IExtension>> { | |||
| let model = await ((query && query.trim() !== '@recommended') ? this.showEmptyModel() : super.show(this.recommendedExtensionsQuery)); | |||
| let shouldShowWorkspaceRecommended = query && (query.trim() === '@recommended' || query.trim() === '@recommended:workspace'); | |||
There was a problem hiding this comment.
When query is an empty string, this will end up showing the empty model, where as all the other views do not do so. So we are not being consistent
ramya-rao-a
approved these changes
Aug 6, 2018
JacksonKearl
pushed a commit
that referenced
this pull request
Aug 6, 2018
…recommendation (#55805) * Fix bug causing workspace recommendations to go away upon ignoring a recommendation * ONly show on @recommended or @recommended:workspace * Make more consistant
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55596, where all workspace recommendations (the pane in the
@recommendedsearch view) would vanish after ignoring any recommendation.I think this should be in July becuase it is pretty jarring and unexpected, and it happens any time you're in the
@recommendedsearch view and ignore any recommenedation