Node should not set supportsTerminateRequest on Windows or in EH debugging

[ramya-rao-a]

• VSCode Version: Insiders 1.26 dated 6th August, 2018
• OS Version: Windows 10

Steps to Reproduce:

1. Have an extension that opens a folder on command

vscode.commands.registerCommand('extension.sayHello', () => {
        vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse('C:/some-local-path'));
    })

2. Debug the extension, run the above command.
3. Close the debugging session, start again

At this point, a new window for extension host is not launched. Clicking the stop button doesnt stop the process either and throws the below error in the debug console

[roblourens]

Is vscode supposed to be sending terminate here? Should the DA be handling the case differently when terminate is called on windows?

[weinand]

On Windows or for extension host debugging the DA should return false for the supportTerminateRequest because:

• sending SIGINT isn't supported on Windows,
• we do not want to have developers interfere with signal handling for extensions.

@roblourens please see the issue I've created against node2: microsoft/vscode-node-debug2#197 (comment)

[roblourens]

Ok, I don't do that.

On windows, why is the DA not normally getting terminate requests? If I debug a normal node app and press stop, the DA doesn't send terminate like on Mac. If it did, we would see this breaking all the time.

[roblourens]

Apparently I didn't read your issue carefully, apologies. This is probably a candidate right?

[roblourens]

That test item should have had a tester assigned for windows...

[weinand]

Yes.

[roblourens]

I've opened a separate issue for the fact that EH debugging is broken.

[roblourens]

microsoft/vscode-node-debug2@82b0830

[roblourens]

To answer my question from above, the reason I didn't get terminate on windows is because Live Share causes that capability to be lost. Like https://github.com/Microsoft/vscode-cascade/issues/69 I think.

This means that this change just causes vscode to officially act the way I've been using it for the past couple weeks.

[kieferrm]

Verified using @roblourens' instructions:

Just do this - debug a node app on windows with "trace": true. Click the stop button. Open the log and verify that From client: terminate( doesn’t show up