(Mac / Linux) node --inspect-brk with auto attach doesn't work

[octref]

I'm on c2ddece with all extension disabled.
This does not happen on Windows.

• Create index.js with the following content

  console.log('foo')
  console.log('bar')

• Put a breakpoint on first line
• Debug: Toggle Auto Attach to turn auto attach on
• Run node --inspect-brk index.js
• Editor do not enter debug mode and no breakpoint gets hit

Node Version: v8.9.2
macOS: High Sierra 10.13.6

[octref]

I was using Code 1.25 on Linux. Turned out this happens on both Mac and Linux.

[roblourens]

I think this is from the terminal process changes. Auto attach looks for --type=terminal which doesn’t exist anymore so it’s completely broken on linux and mac. cc @Tyriar

[Tyriar]

@roblourens that makes sense, processes are now spawned directly under the renderer process.

@weinand let me know your thoughts, I don't think we should backtrack on the process layout. Perhaps looking for terminal processes by searching for the configured shell (terminal.integrated.shell.*) as a child of the renderer process?

[roblourens]

Or just start looking under window.terminals, you can get the processId of a Terminal.

[weinand]

When has this changed? In the test pass last week we found that the process topology had changed for Windows and we fixed that. But macOS and linux was working fine.

[Tyriar]

@weinand merged 25 days ago #54090

@roblourens oh yeah, that's stable now 😄

[weinand]

Verification:

• turn on auto-attach via the "Toggle Auto Attach" action
• use a long-running node.js program "hello.js":

  var i = 0;
  setInterval(() => {
  	console.log('hello world ' + i++);
  }, 1000);
  

• set a breakpoint in line 3
• open integrated terminal
• enter node --inspect hello.js

Debugger should hit breakpoint