-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem entries loops #56317
Comments
Can you please provide a video (gif) of the issue you are seeing? |
Same here. The first line ist a non related (to a file) error. An not clickable. And sometime no line is clickable. Since 1.26. there is a bug. PS: This is not the bottom scroll position. These are all errors. And the first line is a glitch. PPS: Btw. the error should be about "trailing comma". The problems panel displays wrong errors. The trailing comma was behind an object like |
I am experiencing the same in @sandy081 I think you may want to stop the auto updater before this issue is resolved. |
I recommend to use version |
Yep, same issue here. I am noticing that it only happens when the tab is focused, though If I introduce errors in my code while it is not focused, the number changes appropriately, and stays constant. I guess its a workaround, but not much of one. So it must be something about the problems being focused that is triggering the error? |
Callbacks provided to With the Omnisharp C# extension:
For me with VSCode 1.26.0, this breakpoint will constantly trigger, which C# extension isn't really programmed to deal with. |
I’m experiencing the exact same issue as @FranklinWhale with C# |
Same sort of issue here on Win10 x64 with VSCode 1.26.0. Colleague who is running 1.25.1 experiences no issues with the same codebase and plugins. What happens here is that the 1 (correct) warning we have keeps disappearing and then reappearing. |
May I know if any of you were using quick fix from the problems panel while this issue has happened? |
Also it would be great, if any of you can provide steps to reproduce this. |
No quick fix is required to reproduce this issue. Steps to reproduce:
Result: |
In my case there are no steps. 😄 Just load a project (e.g. Ionic / Angular) and have one or more (ts) linter or syntax errors. Just have a error and look to the problems panel. {
"editor.tabSize": 2,
"editor.detectIndentation": false,
"editor.lineNumbers": "on",
"editor.autoClosingBrackets": true,
"editor.selectionHighlight": true,
"editor.occurrencesHighlight": true,
"editor.matchBrackets": true,
"editor.insertSpaces": true,
"editor.renderWhitespace": "all",
"editor.scrollBeyondLastLine": true,
"editor.minimap.enabled": true,
"editor.renderControlCharacters": true,
"editor.renderIndentGuides": true,
"editor.trimAutoWhitespace": true,
"files.trimTrailingWhitespace": true,
"files.insertFinalNewline": true,
"files.trimFinalNewlines": true,
"editor.minimap.showSlider": "always",
"window.zoomLevel": 0,
"beautify.tabSize": 2,
"terminal.integrated.shell.windows": "C:\\Windows\\Sysnative\\cmd.exe",
"workbench.startupEditor": "newUntitledFile",
"explorer.confirmDragAndDrop": false,
"extensions.ignoreRecommendations": false,
"http.proxyStrictSSL": false,
"workbench.statusBar.feedback.visible": false,
"editor.suggestSelection": "first",
"editor.fontSize": 15,
"workbench.colorTheme": "One Dark Pro Vivid",
"diffEditor.ignoreTrimWhitespace": true,
"editor.rulers": [
120
]
} Currently I'm on |
I can confirm this started happening with all my Unity C# projects with v 1.26.0, on Win10x64 + C# plugin v1.15.2. Constantly flicks between "No Problems" and the actual (correct) problems, which appear for 1s before disappearing again. |
@FranklinWhale With your steps I see following. It looks like C# extension is continuously updating the diagnostics and hence problems view is getting updated. @Domvel Looks like you have a different issue that problems view is showing bogus errors. Is it possible to steps to reproduce with some code samples? |
I have the C# flickering issue fixed locally with some modifications to their diagnostics provider, though they seemed pretty confident that it was a VSCode issue over in their repository. |
@sandy081 The issue was reported in dotnet/vscode-csharp#2456 and it was closed |
I accidentially posted this earlier on #56371, sorry! I am on macOS Mojave and here is a sample C# project that can reproduce this. I created it with It becomes more apparent if you also tun on the info level warnings. Add this to your User Settings: |
As I said there are two issues:
This is happening because, whenever problems for a file are shown, problems view asks for the code actions in that file by opening it and closing it after. Looks like the C# extension is reacting to these and generating diagnostics. @rchande Can the C# extension handles this? I will try to see if I can do a fix from our side.
Please refer to #56371 for this. |
@sandy081 Our diagnostics provider tries to react to a variety of events and push diagnostics to a diagnostic collection. It sounds like Code has changed the way it processes/requests diagnostics internally. Can you help me understand exactly what chose changes were? It sounds like we can stop responding to file open/close to push diagnostics. Anything else? |
Sometimes the error checker is looping. But also incorrect and buggy errors in problem panel. In the image you see a corrupt problem panel content. The errors are not clickable. The first error is not related to a source file. ... Oh no, VS code has a cold. 😢 Get well soon! Best wishes. ❤️ Update: Related to #56371 |
I have this same issue on 1.26.0, on Windows; a colleague working on Mac said he had it too, but for him it resolved after restarting Code once. I also noticed the number next to Problems updates as you'd expect when you have that tab open, BUT if you have any other tab open, or close that window entirely, the number always stays at whatever is highest. To me this says it's an error with the Problems tab specifically, and doesn't seem to be an issue with OmniSharp itself; also not that if you're looking at OmniSharp output, it does NOT produce additional output beyond the first time. |
Of course . My case is more related to #56371. |
To verify:
|
Code reviewed |
Verified in 1.26.1-stable |
Steps to Reproduce:
This issue does not occur when C# for Visual Studio Code (powered by OmniSharp) is disabled.
The text was updated successfully, but these errors were encountered: