Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spdlog for output channels straight from the extension host #57618

Closed
alexdima opened this issue Aug 30, 2018 · 0 comments
Closed

Use spdlog for output channels straight from the extension host #57618

alexdima opened this issue Aug 30, 2018 · 0 comments
Assignees
@sandy081
Labels
api feature-request Request for new features or functionality on-testplan output Output channel system issues perf
Milestone
September 2018

Comments

@alexdima
Copy link
Member

  • Communicate the file location from the extension host to the renderer
  • The extension output channel will be sharing the implementation of a regular log channel.
@alexdima alexdima added this to the September 2018 milestone Aug 30, 2018
@alexdima alexdima self-assigned this Aug 30, 2018
@alexdima alexdima added perf output Output channel system issues labels Aug 30, 2018
sandy081 added a commit that referenced this issue Sep 4, 2018
@sandy081
#57618: ExtHost: Implement writable output channels using spdlog
5dbd093
sandy081 added a commit that referenced this issue Sep 4, 2018
@sandy081
#57618 Enable logging output channels
e5a1664
sandy081 added a commit that referenced this issue Sep 4, 2018
@sandy081
#57618 Fix open log output file action
8d0c573
@sandy081 sandy081 mentioned this issue Sep 6, 2018
Merged
sandy081 added a commit that referenced this issue Sep 6, 2018
@sandy081
#57618 Cancelling the model update should reset the model update flag
d559704
@alexdima alexdima removed their assignment Sep 7, 2018
@sandy081 sandy081 added the feature-request Request for new features or functionality label Sep 11, 2018
@sandy081 sandy081 mentioned this issue Sep 12, 2018
Closed
@kieferrm kieferrm mentioned this issue Sep 14, 2018
Closed
18 tasks
@sandy081 sandy081 mentioned this issue Sep 24, 2018
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
api feature-request Request for new features or functionality on-testplan output Output channel system issues perf
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@jrieken @alexdima @sandy081