Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings:SelectBox: Add aria-describedby for extended descriptions #57710

Closed
cleidigh opened this issue Aug 31, 2018 · 4 comments · Fixed by #58129
Closed

Settings:SelectBox: Add aria-describedby for extended descriptions #57710

cleidigh opened this issue Aug 31, 2018 · 4 comments · Fixed by #58129
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues dropdown DropDown (SelectBox widget) native and custom issues settings-editor VS Code settings editor issues verified Verification succeeded

Comments

@cleidigh
Copy link
Contributor

New enum/select box detailed descriptions should be read by reader.
Add describedby attribute handling for details provider within selectbox.

@cleidigh cleidigh self-assigned this Aug 31, 2018
@cleidigh cleidigh added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues dropdown DropDown (SelectBox widget) native and custom issues labels Aug 31, 2018
@cleidigh cleidigh modified the milestones: Backlog, September 2018 Aug 31, 2018
@roblourens
Copy link
Member

Either describedby or just aria-alert

@cleidigh
Copy link
Contributor Author

cleidigh commented Sep 1, 2018

Yep, I've thought about live/alert also.
By my research this does not really match the expected taxonomy for the accessibility tree,
an extended description is pretty much exactly what describedby is for.
That said, describedby probably will not be happy changing which will mean I will need
the static set of descriptions in the Dom. Not a big deal, just another example of where
nothing is straightforward. But, that's why we get paid the big bucks ... well at least you :-o !

What I really want to solve is getting rid of the multiple 'clickable' readings. I think I may have a way to avoid that which will be very important for these descriptions given the number of links.

@roblourens
Copy link
Member

That said, describedby probably will not be happy changing which will mean I will need
the static set of descriptions in the Dom.

Good point, I have no idea if pointing all of the selectbox items at the same details box will work, or if there's something we can do to order events to make it work better. Or maybe changing the 'id' of the details element for each item.

What I really want to solve is getting rid of the multiple 'clickable' readings

I'm very curious what's causing that! Very weird.

@cleidigh
Copy link
Contributor Author

cleidigh commented Sep 1, 2018

describedby can have a list of IDs associated with it. like labeled by and most other ARIA aspects
it does not like things changing underneath it, that of course is what aria-live is for but, but everything I read says use this judiciously. I think having a separate set of descriptions (modified for reader output/minimal clickable) will not be a big deal. Just as the options are static, so are the descriptions
so hiding them in the select for use will not be an issue.

I haven't done the definitive experiment yet but, I believe the multiple clickable issue has to do with something like this:

<div>
<p>this is an extended description <a>link</a></p>
</div>

I think the reader can find these as all clickable elements when they are descendents of a managed
accessibility tree. my research has yet to determine if this is considered a bug or as designed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues dropdown DropDown (SelectBox widget) native and custom issues settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants