Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let debug breakpoint pined to the original line during debug session #57948

Closed
copdips opened this issue Sep 5, 2018 · 6 comments
Closed

Let debug breakpoint pined to the original line during debug session #57948

copdips opened this issue Sep 5, 2018 · 6 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)

Comments

@copdips
Copy link

copdips commented Sep 5, 2018

Hello,

Suppose we add a breakpoint to the line 2, and we insert 3 blank lines before, current version of vscode will keep the breakpoint still at the line 2 which is pointed to a blank line.

original breakpoint:

line1. code1
(breakpoint here) line2. code2

add 3 blank lines before the line 2:

line1. code1
(breakpoint still here) line2. 
line3.
line4.
line5. code2

I expect to see

line1. code1
line2. 
line3
line4
(breakpoint here) line5. code2

Could you please let the breakpoint to pined to the original line code, which means if the original line of code moves, the breakpoint should go with it.

Regards

@vscodebot
Copy link

vscodebot bot commented Sep 5, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@weinand
Copy link
Contributor

weinand commented Sep 5, 2018

I'm not seeing the behaviour you are describing:
2018-09-05_11-32-26

As you can see in the screencast, the breakpoint moves and the line number updates.

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster labels Sep 5, 2018
@copdips
Copy link
Author

copdips commented Sep 5, 2018

@weinand

thx for you rapid reponse, I cannot reproduce the issue neither.
I will raise a new issue next time I encounter it.

@copdips copdips closed this as completed Sep 5, 2018
@copdips copdips reopened this Sep 5, 2018
@copdips
Copy link
Author

copdips commented Sep 5, 2018

@weinand

To reproduce the issue, in fact, it's about to insert lines during debug session.

  1. Set a breakpoint
  2. Start a debug session and wait till the debug stops at the breakpoint
  3. Insert some new line before the line where sits the breakpoint
  4. Save the code
  5. Stop the debug session
  6. The breakpoint doesnt keep with the original code line.

@copdips copdips changed the title Let debug breakpoint pined to the original line Let debug breakpoint pined to the original line during debug session Sep 5, 2018
@weinand
Copy link
Contributor

weinand commented Sep 5, 2018

"Live edit" while a debug session is running only works for debug extensions that support this.
The node-debugger of VS Code does not.
So node.js does not see the edited source which means it hits breakpoints in the original location (even though the breakpoint in the editor shows up in the new location). VS Code shows breakpoint with a grey ring if the breakpoint location does not match what node.js sees.

@weinand
Copy link
Contributor

weinand commented Sep 5, 2018

duplicate of #6930

@weinand weinand closed this as completed Sep 5, 2018
@weinand weinand added *duplicate Issue identified as a duplicate of another issue(s) and removed info-needed Issue requires more information from poster labels Sep 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants