[themes] Foregound Color on Modals and Popups not respecting newly selected theme

[imoby]

• VSCode Version: 1.27.1
• OS Version: macOS High Sierra

Steps to Reproduce:

1. Select a different theme other than dark+ that has themed the foreground different than the default color (example is the shades of purple theme)
2. Set that as the theme and reload vscode
3. Open command palette and attempt to change to new theme
4. Observe that even after selecting a new theme or navigating the themes list, the foreground of the current theme color is being selected instead of the new one or default one

Does this issue occur when all extensions are disabled?: Yes

Images:

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Installed theme only available in one window (#35585)
• Separate workbench theme and syntax theme (#25986)
• [themes] When exiting High Contrast, restore previous color theme (#46862)
• Different themes per window instance (#44268)
• [themes] Disabling default themes results in empty label name (#56702)

[aeschli]

@imoby Thanks a lot for reporting, I've seen something similar, but I'm not able to reproduce with your steps. What theme is that?
Did you by chance define any color customizations in your settings, like:

    "workbench.colorCustomizations": {
		"foreground": "#ff00ff"
	}

[aeschli]

I pushed a fix for what I believe is the problem. Maybe you can try in an insider build if this fixed it for you

[imoby]

@aeschli the issue is still existing even in the latest insiders version. Notice the foreground color even though the Dark+ theme is selected

[imoby]

@aeschli heres a link to a gif on how to reproduce it https://d.pr/i/PK3oZb

[aeschli]

@imoby Did you try with 1.28.0-insider
Commit: 42ffc0e
Date: 2018-09-13T05:22:02.945Z

?