[themes] Foregound Color on Modals and Popups not respecting newly se…

…lected theme. Fixes #58216
microsoft · Sep 12, 2018 · 374daab · 374daab
1 parent 51dd97f
commit 374daab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/vs/code/electron-browser/workbench/workbench.js b/src/vs/code/electron-browser/workbench/workbench.js
@@ -81,6 +81,7 @@ function showPartsSplash(configuration) {
 	const shellBackground = data ? data.colorInfo.editorBackground : configuration.highContrast ? '#000000' : '#1E1E1E';
 	const shellForeground = data ? data.colorInfo.foreground : configuration.highContrast ? '#FFFFFF' : '#CCCCCC';
 	const style = document.createElement('style');
+	style.className = 'initialShellColors';
 	document.head.appendChild(style);
 	document.body.className = `monaco-shell ${baseTheme}`;
 	style.innerHTML = `.monaco-shell { background-color: ${shellBackground}; color: ${shellForeground}; }`;

diff --git a/src/vs/workbench/parts/splash/electron-browser/partsSplash.contribution.ts b/src/vs/workbench/parts/splash/electron-browser/partsSplash.contribution.ts
@@ -102,6 +102,11 @@ class PartsSplash {
 		if (element) {
 			element.remove();
 		}
+		// remove initial colors
+		let defaultStyles = document.head.getElementsByClassName('initialShellColors');
+		if (defaultStyles.length) {
+			document.head.removeChild(defaultStyles[0]);
+		}
 	}
 }