Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untitled: reveal when saving #58799

Closed
bpasero opened this issue Sep 17, 2018 · 3 comments
Closed

Untitled: reveal when saving #58799

bpasero opened this issue Sep 17, 2018 · 3 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone
September 2018

Comments

@bpasero
Copy link
Member

bpasero commented Sep 17, 2018

When saving untitled files, we should open them in the background so that a filename can more easily be determined based on the contents. Extracted from #37414
@bpasero bpasero added feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window labels Sep 17, 2018
@bpasero bpasero added this to the September 2018 milestone Sep 17, 2018
@bpasero bpasero self-assigned this Sep 17, 2018
@bpasero bpasero mentioned this issue Sep 17, 2018
Closed
@bpasero bpasero closed this as completed Sep 17, 2018
@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 17, 2018
bpasero added a commit that referenced this issue Sep 17, 2018
@bpasero
fix #58799
091c626
@isidorn
Copy link
Contributor

isidorn commented Sep 25, 2018

Verification steps?
If I just save an untitled file I see no difference than before

@isidorn isidorn added the verification-steps-needed Steps to verify are needed for verification label Sep 25, 2018
@bpasero
Copy link
Member Author

bpasero commented Sep 25, 2018

@isidorn open multiple untitled files and trigger "Save All". at each dialog that opens, the file in the background should become active that is being saved.

@isidorn
Copy link
Contributor

isidorn commented Sep 25, 2018

@bpasero works great, thanks for claryfing

@isidorn isidorn added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Sep 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
2 participants
@bpasero @isidorn